Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BRD Song "Pining Nocturne" Missing from spell_list.sql. #4778

Open
3 tasks done
UmeboshiXI opened this issue Nov 27, 2023 · 2 comments · May be fixed by #6677
Open
3 tasks done

🐛 BRD Song "Pining Nocturne" Missing from spell_list.sql. #4778

UmeboshiXI opened this issue Nov 27, 2023 · 2 comments · May be fixed by #6677
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@UmeboshiXI
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

Open spell_list.sql, see that the entry is not captured/missing. Spell Enum in lua shows spell ID as 472.

Expected behavior

Should be an entry here when we get captures for it. Simply posting a bug report to bring visibility.
@UmeboshiXI UmeboshiXI added the bug Something isn't working label Nov 27, 2023
@zach2good zach2good added the good first issue Good for newcomers label Apr 30, 2024
@RaraProjects
Copy link

I can do this one. I've added the SQL entry on my local instance and I'm able to cast it in game. I also need to fill out the Lua for the spell itself which is a little more complicated. I don't see a way to assign myself to this issue though.

@WinterSolstice8
Copy link
Member

No need to assign, just make a PR with the text Closes #4778 in the "what does this do?" section

@RaraProjects RaraProjects linked a pull request Jan 9, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Bard Song: Pining Nocturne RaraProjects/RaraXI
4 participants
@zach2good @UmeboshiXI @WinterSolstice8 @RaraProjects