Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to rename an option in a table, ends up succeeding but list of options doesn't reflect changes #405

Open
eidolies opened this issue Jan 4, 2025 · 1 comment

Comments

@eidolies
Copy link

eidolies commented Jan 4, 2025

With Make.md 1.0.2 on Obsidian 1.5.3 (linux)

When renaming the option name in the submenu, pressing Enter after entering the new name does nothing but makes the menu disappear leaving the submenu on screen. Re-doing the same thing reverts back to the original name. cf. video below

Peek.2025-01-04.21-09.mp4

(cameo appearances of #402 at 1:29 and #399 at 1:37)

Figured out how to managed to rename an option, but it's surely not by design. It's a tedious process:

  1. Drop down arrow on the list of names (same as in the video at 0:42) to show the menu.
  2. Select ... to show the submenu.
  3. Click on text field and change the name.
  4. Pressing [Enter] will make the menu disappear, leaving the submenu on screen, but won't affect the name, which will revert back to its original value.
  5. Change again the name to the value you want (demonstrated at 1:15)
  6. Press [Enter]
  7. Click outside of the submenu, in an empty space
  8. Go back to the list of options (step 1).
  9. The name in the list still has the name it was originally created as, but: a) when selected, it will show the new name in the cell; b) when attempting to rename it, it will show the new name as well.

So the expected behaviour is: the name in the list of options should reflect the renamed name, disappearing menus shouldn't disappear, and a visual indication should make us understand that the rename succeeded.

@jp-cen
Copy link
Contributor

jp-cen commented Jan 4, 2025

Thanks, looking into why this is happening in the next patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants