Remove text in the Activity empty state #26669
Assignees
Labels
area-design
Design bug (previously known as papercuts - ask Hilary for more detail)
release-12.11.0
Issue or pull request that will be included in release 12.11.0
type-enhancement
Comments
amandaye0h
added
type-enhancement
area-design
|
Ch duh j it |
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 20, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR updates the Activity empty state by removing the placeholder text. The change simplifies the UI, ensuring a cleaner and more visually appealing experience when no activity is present. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/29318?quickstart=1) ## **Related issues** Fixes: #26669 ## **Manual testing steps** 1. Go to activity tab for any network where you don't have transactions 2. check the message ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> <img width="416" alt="Screenshot 2024-12-18 at 13 35 07" src="https://github.com/user-attachments/assets/7e0d335c-bab2-48b8-8cec-55c5bae10805" /> ### **After** <img width="411" alt="Screenshot 2024-12-18 at 13 35 12" src="https://github.com/user-attachments/assets/ad374d71-3743-4f2a-93a0-6e4e5f6965b4" /> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/29318?quickstart=1){kind=link}
metamaskbot
added
the
release-12.11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
What is this about?
The implementation of the Ramps card has resulted in conflicting hierarchy in the Activity empty state
Scenario
No response
Design
Figma link
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
"You have no transactions" and MetaMask support link have been removed.
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: