Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Assets - Watching multiple NFTs displays navigation header in the UI which is broken as everything is consolidated in 1 screen #29189

Closed
seaona opened this issue Dec 13, 2024 · 0 comments · Fixed by #29279
Closed

[Bug]: Assets - Watching multiple NFTs displays navigation header in the UI which is broken as everything is consolidated in 1 screen #29189

seaona opened this issue Dec 13, 2024 · 0 comments · Fixed by #29279
Assignees
@matthewwalsh0
Labels
regression-RC-12.10.0 Regression bug that was found in release candidate (RC) for release 12.10.0 release-12.11.0 Issue or pull request that will be included in release 12.11.0 release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Dec 13, 2024 •
edited
Loading

Describe the bug

Watching multiple NFTs opens 1 UI screen with everything consolidated, however now there's a navigation header which appears on top, and it is broken, which is expected since in reality it's only 1 UI screen consolidating all assets

Expected behavior

If we are trying to watch for multiple assets, that's consolidated in 1 screen, so we shouldn't display the navigation header, as it's just 1 screen?

Screenshots/Recordings

watchh-multiple-assets.mp4
watch-all-notifications.mp4

This is current prod 12.9.1, where there' s no navigation header:

Image

Steps to reproduce

  1. Go to the test dapp
  2. Deploy an ERC721 contract
  3. Mint some tokens
  4. Watch multiple assets (or Watch all assets)
  5. See how the notification number increases, but you cannot navigate to the different screens since everything is aggregated to 1 screen

Error messages or log output



Detection stage


During release testing


Version


12.10.0


Build type


None


Browser


Chrome


Operating system


Linux


Hardware wallet


No response


Additional context


No response


Severity


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            


    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Dec 13, 2024

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by team


      Dec 13, 2024

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  regression-RC-12.10.0

  Regression bug that was found in release candidate (RC) for release 12.10.0
 label


      Dec 13, 2024

    

  



    

    

      
    

    


      

          @seaona
seaona




            added
      

  Sev2-normal

  Normal severity; minor loss of service or inconvenience.

      

  team-assets


      

  release-blocker

  This bug is blocking the next release

  labels


      Dec 13, 2024

    

  



  

  

    
  


  

      

    @seaona
seaona



    mentioned this issue
    
      Dec 13, 2024
    





  


  

      
  
  Closed

  







  




    

    

      
    

    


      

          @bschorchit
bschorchit




            added
      

  team-confirmations

  Push issues to confirmations team

    and removed
      

  team-assets


  labels


      Dec 13, 2024

    

  



    


  

  

    
  


  

      

    @matthewwalsh0
matthewwalsh0



    mentioned this issue
    
      Dec 17, 2024
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




    


  


  
    
  
  

    
  github-merge-queue bot

      pushed a commit
      that referenced
      this issue

    
      Dec 20, 2024
    
    

      


  

    

      


  

      
        @matthewwalsh0
  





      

        
          fix: navigation between watch asset approvals (#29279)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          fde9fa1
        
      

    

  

    

      
## **Description**

Ignore any additional watch token and watch NFT approvals in the
confirmation navigation, since both types of watch asset confirmation
combine data from multiple approval requests.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29279?quickstart=1)

## **Related issues**

Fixes: #29189 

## **Manual testing steps**

See issue.

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  




    

    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by severity


      Dec 20, 2024

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by team


      Dec 20, 2024

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  release-12.11.0

  Issue or pull request that will be included in release 12.11.0
 label


      Dec 20, 2024

    

  



  


  
    
  
  

    
  matthewwalsh0 

      added a commit
      that referenced
      this issue

    
      Dec 20, 2024
    
    

      


  

    

      


  

      
        @matthewwalsh0
  





      

        
          fix: navigation between watch asset approvals (#29279)
        

          
            
          

      


      

          

    
    
    

  

      


      

          

    
    
    

  

  

    
  



      


      
      

        
          c9d0370
        
      

    

  

    

      
## **Description**

Ignore any additional watch token and watch NFT approvals in the
confirmation navigation, since both types of watch asset confirmation
combine data from multiple approval requests.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29279?quickstart=1)

## **Related issues**

Fixes: #29189 

## **Manual testing steps**

See issue.

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @matthewwalsh0
  
    matthewwalsh0
    

      








      


  


  

    Labels
  



    

      

    regression-RC-12.10.0

  Regression bug that was found in release candidate (RC) for release 12.10.0
  

    release-12.11.0

  Issue or pull request that will be included in release 12.11.0
  

    release-blocker

  This bug is blocking the next release
  

    Sev2-normal

  Normal severity; minor loss of service or inconvenience.
  

    team-confirmations

  Push issues to confirmations team
  

    type-bug









      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

          

  

    
      Archived in project



      

    

    

  



        
  

    

      
          
        Bugs by team
        
    

    

      

            
    Status: Fixed

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      fix: navigation between watch asset approvals

    
      MetaMask/metamask-extension
    





    
  




      

    

  
      

  

    

      5 participants
    

    

        
          @matthewwalsh0 
        
          @bschorchit 
        
          @metamaskbot 
        
          @seaona 
        
          @sleepytanya