Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isSnapId from @metamask/snaps-utils #29280

Closed
GuillaumeRx opened this issue Dec 17, 2024 · 0 comments · Fixed by #29422
Closed

Use isSnapId from @metamask/snaps-utils #29280

GuillaumeRx opened this issue Dec 17, 2024 · 0 comments · Fixed by #29422
Assignees
@hmalik88
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-snaps-platform Snaps Platform team

Comments

@GuillaumeRx
Copy link
Contributor

Remove the local definition of isSnapId and use the one from @metamask/snaps-utils
@GuillaumeRx GuillaumeRx mentioned this issue Dec 17, 2024
Merged
7 tasks
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Dec 17, 2024
@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label Dec 17, 2024
@hmalik88 hmalik88 mentioned this issue Dec 25, 2024
Merged
7 tasks
@hmalik88 hmalik88 self-assigned this Dec 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 6, 2025
@hmalik88
chore: replace local isSnapId definition with isSnapId from `@met…
c7d14a0 
…amask/snaps-utils` (#29422)

## **Description**

Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change? Deduplication of code
2. What is the improvement/solution? Using the `isSnapId` function from
the `@metamask/snaps-utils` package.

## **Related issues**

Fixes: #29280 

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmalik88 hmalik88

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-snaps-platform Snaps Platform team
Projects
None yet
Milestone
No milestone
4 participants
@FrederikBolding @GuillaumeRx @metamaskbot @hmalik88