[Bug]: metamaskbot broken beta build links
#29404
Labels
Comments
Gudahtt
added
area-CI
Sev3-low
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 7, 2025
## **Description** Various build links in the `metamaskbot` PR comment were broken. All links have been fixed except beta (which is trickier to fix, requires more substantial changes to the beta workflows, tracked as #29404). The beta link has been removed until we can fix it. Additionally, the Firefox MMI build link has been removed (this build does not work) [](https://codespaces.new/MetaMask/metamask-extension/pull/29403?quickstart=1) ## **Related issues** Fixes: #29402 ## **Manual testing steps** * Test that all build links work ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/29403?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Describe the bug
Each
metamaskbotPR comment includes broken beta build links. We don't currently produce beta builds as part of PR status checks. The links were temporarily removed in #29403 but we still need them shown when a beta build is triggered.Expected behavior
Either create beta builds and link them, or conditionally show the links (correctly) only when a beta build was triggered.
Screenshots/Recordings
No response
Steps to reproduce
Example: #29371 (comment)
Error messages or log output
Detection stage
On main branch
Version
main
Build type
Other (please specify exactly where you obtained this build in "Additional Context" section)
Browser
Other (please elaborate in the "Additional Context" section)
Operating system
Other (please elaborate in the "Additional Context" section)
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: