Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichain API e2e test: calling wallet_invokeMethod on the same dapp across three different connected chains#3836 #29522

Open
wants to merge 8 commits into
base: jl/caip-multichain-migrate-core
Choose a base branch
from

Conversation

ffmcgee725
Copy link
Member

@ffmcgee725 ffmcgee725 commented Jan 8, 2025

-- test: add wallet_invokeMethod end to end test cases

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

socket-security bot commented Jan 8, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 1.69 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [4f7a587]
Page Load Metrics (1625 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39918781562283136
domContentLoaded1483185915999646
load1524187416258943
domInteractive249941199
backgroundConnect798262311
firstReactRender1597502914
getState46411147
initialActions01000
loadScripts1059139211778239
setupStore67114189
uiStartup168824731909207100

@adonesky1
Copy link
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@ffmcgee725 ffmcgee725 requested review from adonesky1 and jiexi January 9, 2025 13:37
Copy link
Contributor

github-actions bot commented Jan 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1
Copy link
Contributor

Looks like the test is failing in CI -> balance after eth_sendTransaction is not matching expected result

@ffmcgee725
Copy link
Member Author

@adonesky1 I commited a change I shouldn't have (was locally testing something). It should be passing now 👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants