Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-create nextjs build fix pr #1163

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

christopherferreira9
Copy link
Collaborator

@christopherferreira9 christopherferreira9 commented Dec 11, 2024

Explanation

This PR removes the exports field from the Metamask SDK package.json to resolve build issues experienced in Next.js + Wagmi integrations. It also upgrades TypeScript to ensure compatibility and maintain stable compilation after removing the exports configuration.

Re-create #1161

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner December 11, 2024 12:38
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.12%. Comparing base (86b8b05) to head (df37c32).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1163   +/-   ##
=======================================
  Coverage   74.12%   74.12%           
=======================================
  Files         181      181           
  Lines        4298     4298           
  Branches     1053     1053           
=======================================
  Hits         3186     3186           
  Misses       1112     1112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@chakra-guy chakra-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 merged commit 169b3a3 into main Dec 11, 2024
36 checks passed
@christopherferreira9 christopherferreira9 deleted the fix-nextjs-bundling-issue-pr-rebuild branch December 11, 2024 15:54
@christopherferreira9 christopherferreira9 mentioned this pull request Dec 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants