From f228b53d0dfa6a29f85f7b57ae51ce68f20f4db3 Mon Sep 17 00:00:00 2001 From: Fabiana Campanari Date: Mon, 4 Mar 2024 22:16:16 -0300 Subject: [PATCH] Update contributing_renovate.md Signed-off-by: Fabiana Campanari --- .github/contributing_renovate.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/contributing_renovate.md b/.github/contributing_renovate.md index da56012..56eedde 100644 --- a/.github/contributing_renovate.md +++ b/.github/contributing_renovate.md @@ -98,3 +98,11 @@ Maintainers can suggest changes while reviewing your pull request, please follow 1. Select the **Commit suggestions** button Read the [GitHub docs, Applying suggested changes](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes) to learn more. + +## Resolve review comments instead of commenting + +A maintainer/contributor can ask you to make changes, without giving you a _suggestion_ that you can apply. +In this case you should make the necessary changes. + +Once you've done the work, resolve the conversation by selecting the **Resolve conversation** button in the PR overview. +Avoid posting comments like "I've done the work", or "Done".