Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend offline_check_fortran_vs_metadata.py to log what it has checked #592

Open
peverwhee opened this issue Sep 26, 2024 · 0 comments
Open

Comments

@peverwhee
Copy link
Collaborator

Description

The offline_check_fortran_vs_metadata.py checker currently exercises this function:

def compare_fortran_and_metadata(scheme_directory, run_env):
    ## Check for files
    metadata_files = find_files_to_compare(scheme_directory)
    # Perform checks
    parse_scheme_files(metadata_files, run_env, skip_ddt_check=True)

If you pass the checker a directory that contains no .meta files, it will check nothing and return "All checks pass!", which implies it checked something when it really didn't.

Solution

Either:

  1. Log something like "No metadata files found in directory tree provided" if find_files_to_compare returns [], AND/OR
  2. Log each metadata file checked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant