Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_name! with existing name errors #397

Open
GabrielKS opened this issue Sep 12, 2024 · 2 comments
Open

set_name! with existing name errors #397

GabrielKS opened this issue Sep 12, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@GabrielKS
Copy link
Contributor

The IS companion to NREL-Sienna/PowerSystems.jl#1161. If one sets a component's name to that component's existing name:
Screenshot 2024-09-12 at 5 25 50 PM
it is an error. I propose we add a special case in set_name! to turn this into a no-op.
@GabrielKS GabrielKS mentioned this issue Sep 12, 2024
Open
@jd-lara
Copy link
Member

jd-lara commented Sep 13, 2024

Why would this operation happen?

@GabrielKS
Copy link
Contributor Author

Why would this operation happen?

Seems unlikely for someone to intentionally do this as a one-off, but maybe it could occur as part of some batch process. Anyway, even if it is unlikely to happen, it still strikes me as buggy behavior we ought to fix.

@GabrielKS GabrielKS added the good first issue Good for newcomers label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jd-lara @GabrielKS