Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_load_data bug using AbstractDeterministic #31

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

GabrielKS
Copy link
Collaborator

The get_load_data function was manually filtering to only Deterministic time series, which was excluding DeterministicSingleTimeSeries. The fix is to use AbstractDeterministic to catch both. Here I do that and add a test.

See also NREL-Sienna/InfrastructureSystems.jl#378.

@GabrielKS GabrielKS self-assigned this Dec 17, 2024
@GabrielKS GabrielKS requested a review from jd-lara December 17, 2024 20:31
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (f976364) to head (68eee1b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files           3        3           
  Lines         321      321           
=======================================
  Hits          283      283           
  Misses         38       38           
Flag Coverage Δ
unittests 88.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabrielKS GabrielKS merged commit c536d05 into main Dec 17, 2024
7 checks passed
@GabrielKS GabrielKS deleted the gks/fix_get_load branch December 17, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants