Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for large number of items to DeviceSelect #1584

Closed
Tracked by #1422
elstehle opened this issue Apr 3, 2024 · 0 comments · Fixed by #1612
Closed
Tracked by #1422

Add tests for large number of items to DeviceSelect #1584

elstehle opened this issue Apr 3, 2024 · 0 comments · Fixed by #1612
Assignees

Comments

@elstehle
Copy link
Collaborator

elstehle commented Apr 3, 2024

In PR #1379, we consolidated thrust::copy_if to use cub::DeviceSelect. Along with that change, we made thrust to dispatch using offset types using i64 if the given number of items was exceeding INT_MAX.

Testing for large number of items in thrust::copy_if has been limited to some sanity tests.

We want to have more elaborate test coverage by adding tests for large number of items to the CUB tests of cub::DeviceSelect, since we have better testing infrastructure in CUB.

However, until we agree on a scheme for offset type handling in #50, cub::DeviceSelect still only uses hard-coded int offset types. To be able to still test DeviceSelect for large number of items, we want to directly use the Dispatch layer, which allows instantiating the algorithm for wider offset types.

@github-project-automation github-project-automation bot moved this to Todo in CCCL Apr 3, 2024
@elstehle elstehle changed the title add tests for inputs larger than std::numeric_limits<uint32_t>::max() Add tests for large number of items to DeviceSelect Apr 3, 2024
@elstehle elstehle self-assigned this Apr 3, 2024
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Apr 10, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant