Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: sm_100 missing from <nv/target> #2890

Closed
1 task done
dkolsen-pgi opened this issue Nov 19, 2024 · 1 comment · Fixed by #2954
Closed
1 task done

[BUG]: sm_100 missing from <nv/target> #2890

dkolsen-pgi opened this issue Nov 19, 2024 · 1 comment · Fixed by #2954
Labels
bug Something isn't working right.

Comments

@dkolsen-pgi
Copy link
Collaborator

Is this a duplicate?

Type of Bug

Compile-time Error

Component

libcu++

Describe the bug

Support for sm_100 was added to <nv/__detail/__target_macros> in #1745, so it works for NVCC. But the corresponding change was not made to <nv/target>. When compiling with NVC++, the macro NV_PROVIDES_SM_100 references sm_100, but that doesn't exist and compilation fails.

How to Reproduce

$ cat sm100.cpp
#include <nv/target>
int main() {
  if target (provides(nv::target::sm_100)) { return 100; }
}
$ nvc++ sm100.cpp
"sm100.cpp", line 3: error: namespace "nv::target" has no member "sm_100"
    if target (provides(nv::target::sm_100)) { return 100; }
                                    ^

"sm100.cpp", line 3: error: identifier "provides" is undefined
    if target (provides(nv::target::sm_100)) { return 100; }
               ^

2 errors detected in the compilation of "sm100.cpp".

Expected behavior

nv::target::sm_100 should be defined when <nv/target> is included.

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response

@dkolsen-pgi dkolsen-pgi added the bug Something isn't working right. label Nov 19, 2024
@dkolsen-pgi
Copy link
Collaborator Author

(NVHPC tracking: FS#36792 )

miscco added a commit to miscco/cccl that referenced this issue Nov 25, 2024
This is adding the missing sm_100 identifier to nv/target

Fixes NVIDIA#2890
@miscco miscco closed this as completed in 5ad00af Nov 25, 2024
davebayer pushed a commit to davebayer/cccl that referenced this issue Nov 25, 2024
This is adding the missing sm_100 identifier to nv/target

Fixes NVIDIA#2890
davebayer pushed a commit to davebayer/cccl that referenced this issue Dec 2, 2024
This is adding the missing sm_100 identifier to nv/target

Fixes NVIDIA#2890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant