From c134d76d954877bbe0d3dcdd4f05cd2a99775573 Mon Sep 17 00:00:00 2001 From: SriHV Date: Thu, 9 Jan 2025 18:57:17 +0000 Subject: [PATCH] changes as per comments --- ...mponents_hero_example-hero-grey_0_document_0_desktop.png | 4 ++-- ...omponents_hero_example-hero-grey_0_document_1_tablet.png | 4 ++-- ...omponents_hero_example-hero-grey_0_document_2_mobile.png | 4 ++-- src/components/hero/_hero.scss | 6 ++++++ 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_0_desktop.png b/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_0_desktop.png index 06a381f551..fed0fc64cd 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_0_desktop.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_0_desktop.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:c4a712b772a05d44201e554cf4eb0e2e4df87ce217153d1186d5f40ce58a45db -size 79749 +oid sha256:d1281c7b5cc116410f9add67692e230581ce5b8e4976d2ac8e20c46cd59e020f +size 79351 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_1_tablet.png b/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_1_tablet.png index 2ab2626cdb..ca759aecbd 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_1_tablet.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_1_tablet.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:9d2ee23654d10bdd972b002cf5bd94466bb64d84d2205057e4e348a4c2b302d6 -size 77178 +oid sha256:e3bce5cf21914ebf9ba6b4a848c59cccc1ca209882f446603737f4fad82b01f6 +size 77032 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_2_mobile.png b/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_2_mobile.png index c3964d8414..c2ec970118 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_2_mobile.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_2_mobile.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:fae649d71c4bb4ea9011caf02b41ae5985a0361e442c58e2adbb62c3d0ae7a65 -size 72279 +oid sha256:8b5618c2c948e45ae4abd65f46b65afd0bb4a6ba49b4d13544528ef2a524a684 +size 72186 diff --git a/src/components/hero/_hero.scss b/src/components/hero/_hero.scss index 5fcaf6befa..6ea97bdd89 100644 --- a/src/components/hero/_hero.scss +++ b/src/components/hero/_hero.scss @@ -87,6 +87,12 @@ z-index: 5; } + &--grey & { + &__details { + padding-top: 1rem; + } + } + &--dark & { &__details { color: var(--ons-color-text-inverse) !important;