Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message body omitted from description list #3427

Open
pricem14pc opened this issue Nov 19, 2024 · 1 comment
Open

Message body omitted from description list #3427

pricem14pc opened this issue Nov 19, 2024 · 1 comment
Labels
Accessibility Issues discovered through accessibility testing Community backlog An issue raised on the community backlog

Comments

@pricem14pc
Copy link

pricem14pc commented Nov 19, 2024

Describe the accessibility issue

A recent SDC Respondent Account Service DAC report raised an accessibility issue against our secure message page which renders the following component

https://service-manual.ons.gov.uk/design-system/patterns/send-and-reply-to-messages#example.example-message-list.html

The issue has been raised under

Related content

Related content was not marked up programmatically
WCAG Reference:
1.3.1 Info and Relationships (Level A)
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html | https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships_

Detailing our specific usage as

The contents of the message entitled '...' has a clear visual relationship with the contents of the, however, it has been omitted from the description list. This may leave some blind users unaware of what the message relates to as it sits alone '...' outside of the description list grouping.

Screenshot 2024-11-19 at 08 24 27

Their recommendation is to move the text element of the message with the class ons-message-item__body from its own <div> into the <dl> along with the other <dt><dd> pairings. They suggest optionally hiding the text element's corresponding <dt> if it does not require a visual 'label'.

Expected behaviour / outcome

Screen readers to better associate the message body along with the preceding related description list terms.

List the steps necessary to reproduce the bug

n/a

Additional context

n/a

What version of the ONS Design System are you using?

In the process of upgrading from 70.0.1 to 72

What device(s) are you using?

Desktop

What operating system(s) are you using?

macOS

What browser(s) are you using?

Chrome

@pricem14pc pricem14pc added Bug Something isn't working Community backlog An issue raised on the community backlog High priority Accessibility Issues discovered through accessibility testing and removed Bug Something isn't working High priority labels Nov 19, 2024
@pricem14pc pricem14pc changed the title [Bug]: Message body omitted from description list (accessibility) [Bug]: Message body omitted from description list Nov 19, 2024
@pricem14pc pricem14pc changed the title [Bug]: Message body omitted from description list Message body omitted from description list Nov 19, 2024
@MagdalenaLarge
Copy link

Hello @pricem14pc,
Thank you for raising this issue with us. We will investigate it and update you once we agree further actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues discovered through accessibility testing Community backlog An issue raised on the community backlog
Projects
None yet
Development

No branches or pull requests

2 participants