Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maximum length requirement for API key #102

Open
kengel100 opened this issue Apr 12, 2021 · 0 comments
Open

Remove maximum length requirement for API key #102

kengel100 opened this issue Apr 12, 2021 · 0 comments

Comments

@kengel100
Copy link

Is there a reason to specify max length for API key in integrations?
Eg https://github.com/OctopusDeploy/OctoTFS/pull/187/files and https://github.com/OctopusDeploy/octopus-jenkins-plugin/pull/98/files

If Core extends the API key length again these integrations will break again. (Currently, there aren't any plans to make it longer.)
We could consider adding data contracts and safety nets to Core, but the question came up as to why integrations rely on a specific length.

Note: other integrations may also have maximum length hardcoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant