Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin is not deployed correctly #60

Open
oleg-nenashev opened this issue Dec 10, 2019 · 6 comments
Open

The plugin is not deployed correctly #60

oleg-nenashev opened this issue Dec 10, 2019 · 6 comments

Comments

@oleg-nenashev
Copy link

Hi, please see the discussion in https://groups.google.com/forum/#!topic/jenkinsci-dev/ykKUGJ7zZEQ . The plugin is currently hosted inside the jenkinsci, and we expect it to be master repository for the plugin. Otherwise it may confuse other contributors and cause split-brain in repos.

If it is not possible, please let us know in the thread

@tothegills
Copy link
Contributor

Thanks @oleg-nenashev, we opted for keeping the Octopus Deploy repository as the root and deploy from our own pipeline to make the development and deployment process consistent across our plugin offerings.

If that is incompatible with Jenkins policy we can move it to the jenkinci organisation. In the thread you link I see:

FTR the plugin site currently does not support non-jenkinsci organizations as a source of plugin documentation.

We have been scratching our heads trying to figure out why the documentation was not being shown on the plugin page, so this is a deal maker for us.

Is it possible for the Octopus Deploy organization to have review and merge permissions for the Octopus plugin repository hosted on jenkinsci?

@oleg-nenashev
Copy link
Author

The preference would be to have the plugin hosted on jenkinsci. With all pros and cons, this is what helps us to keep the Jenkins plugin governance more or less aligned.

Is it possible for the Octopus Deploy organization to have review and merge permissions for the Octopus plugin repository hosted on jenkinsci

Yes, it is possible to add multiple contributors to the jenkinsci repo. There is also a plan to introduce company/team ownership soon to make it explicit that a plugin is maintained by a company.

@tothegills
Copy link
Contributor

company/team ownership soon to make it explicit that a plugin is maintained by a company

This would be a huge win for us.

Can you get me pointed in the right direction to add contributors to the jenkinsci repo? We can get the ball rolling making jenkinsci the root repository.

@oleg-nenashev
Copy link
Author

According to the https://github.com/jenkinsci/octopusdeploy-plugin repo, the only contributor with a write access is @badriance . Taking the explicit confirmation in jenkins-infra/repository-permissions-updater#1194 , I can add all you, @hnrkndrssn and all other GitHub users you specify to the plugin maintainers team on GitHub

Since jenkins-infra/repository-permissions-updater#1194 sets a company account as a maintainer, I believe that the "company ownership" concept already applies here. FYI @daniel-beck

@tothegills
Copy link
Contributor

Appreciate if you could add the following as maintainers:

@tothegills
@hnrkndrssn
@NickJosevski
@slewis74
@droyad
@pawelpabich
@michaelnoonan

Thank you!

@mcasperson
Copy link
Contributor

Hi @oleg-nenashev, it appears that the list mentioned by @tothegills above are not maintainers of the repo. Are you able to provide that access?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants