Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heart win conditions incompatible with Scarce and Minimal item pools #1644

Open
mracsys opened this issue Jul 19, 2022 · 4 comments · May be fixed by #2182
Open

Heart win conditions incompatible with Scarce and Minimal item pools #1644

mracsys opened this issue Jul 19, 2022 · 4 comments · May be fixed by #2182
Labels
Component: Setting specific to setting(s) Type: Bug Something isn't working

Comments

@mracsys
Copy link

mracsys commented Jul 19, 2022

The scarce and minimal item pool settings remove heart pieces and heart containers, respectively, from the item pool. The win conditions for Rainbow Bridge and Ganon's Boss Key can still expect up to 20 heart containers even though less than 20 exist in the pool. Generation will always fail with this setting combination as the game is unbeatable. Possible suggestions for resolution:

  1. Change pool settings as follows:
    a. Scarce: Maintain 20 containers worth of heart pieces in the pool instead of only removing the heart containers
    b. Minimal: Maintain required containers worth of heart pieces in the pool. If there are no heart wincons, this would be 0 like before.
  2. Disable these options when one or the other is selected. May require GUI framework upgrades.
  3. Add tooltips to both the wincon selection for hearts and the item pool explaining the settings are not compatible. Include a custom error message instead of Item pool does not contain items required to beat game! for this case if the tooltips are ignored.
@cjohnson57
Copy link
Collaborator

I think option 1 is preferable, as long as if only effects the pools when heart wincons are on

@LostThePirate
Copy link

My 2¢, I think it would be better to make them officially incompatible. Changing the way Scarce and Minimal work in just this one setting is an inelegant solution (especially since it differs from how they would behave otherwise re: converting all 17 (or less with extra starting hearts) hearts into either HPs or HCs). I think just accepting that some things don't work together is better than shoehorning in compatibility with settings that, in there basic descriptions, clearly can't be utilized together.

@r0bd0g
Copy link

r0bd0g commented Jan 13, 2023

I think it might be a good time to decouple the item pool setting from the number of available hearts. I think this is a good idea regardless of the existence of the heart wincon, because I think people not confident in combat ability might still enjoy occasionally playing with low major item availability. It was suggested to turn starting hearts then into a double slider, with total available hearts at the top. Nobody has implemented double sliders yet.

(And doing that might free up some options for what to do about this issue. Personally I think I would expect to not be able to select a wincon with more hearts that I've set to be available. So if you implement the above slider, you could tie that and the heart wincon slider together in some way. Maybe make sure they're not too far apart from each other so people can see the relation. And I doubt anybody has set up a way of handling that in the GUI either lol.)

@RawZ06
Copy link

RawZ06 commented Feb 6, 2023

Intuitively, I thought Scarce and Minimal are available and with minimal i've only PoH required to the bridge or BK and in Scarce, I've all PoH to have 20 hearts.
I like the @r0bd0g solution, today we can use plandomizer to change item pool manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Setting specific to setting(s) Type: Bug Something isn't working
Projects
None yet
6 participants