Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precommit: Use https://pre-commit.com/ instead? #225

Open
ghost opened this issue Dec 14, 2022 · 2 comments
Open

Precommit: Use https://pre-commit.com/ instead? #225

ghost opened this issue Dec 14, 2022 · 2 comments
Labels
Build This issue relates to the build process

Comments

@ghost
Copy link

ghost commented Dec 14, 2022

Split out from #19

@duncandewhurst duncandewhurst added the Build This issue relates to the build process label Dec 16, 2022
@ghost ghost changed the title Precommit: Use https://pre-commit.ci/ instead? Precommit: Use https://pre-commit.com/ instead? Dec 20, 2022
@ghost
Copy link
Author

ghost commented Dec 20, 2022

Note https://pre-commit.com/ is a Python tool

And https://pre-commit.ci/ is their CI offering

We can use just the former (via GH Actions) or both.


I've had a quick look and I think some conversion work will be needed, due to it's model of running precommit functions from other repos - (eg black, isort). That makes sense in a lot of cases (eg black, isort) but we also want to run precommit functions from this repo, and I haven't yet seen an easy way to do this. So this won't be a fast conversion, and thus I'll leave it for now.

@ghost
Copy link
Author

ghost commented Dec 20, 2022

@duncandewhurst duncandewhurst added this to the Minor: Build changes milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build This issue relates to the build process
Projects
None yet
Development

No branches or pull requests

1 participant