Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the duct type associated with a span #249

Open
lgs85 opened this issue Jan 25, 2023 · 6 comments
Open

Specify the duct type associated with a span #249

lgs85 opened this issue Jan 25, 2023 · 6 comments
Labels

Comments

@lgs85
Copy link
Contributor

lgs85 commented Jan 25, 2023

A call with stakeholders today surfaced a need to be able to specify the duct type associated with a span. The stakeholder stated that they use an ISO standard to specify this, and I've requested more details.

We don't currently support anything like a duct type in OFDS. Ducts could be represented as an additional layer of structure in the data model. Alternatively (and preferably if it works) we may be able to add one or more additional fields at the span level to accommodate this.

Flagging here that this may be a priority issue to address

@lgs85 lgs85 added the Schema label Jan 25, 2023
@stevesong
Copy link
Contributor

I think we do have to support this in some way in the standard. It does prompt the question of where exactly the boundaries of Open Fibre Data lie.

@duncandewhurst
Copy link
Collaborator

Thanks for sharing this feedback! A couple of questions:

  1. What is meant by 'type' in this context?
  2. Who would use this data and to what end?

In #192 (comment), we discussed creating a Cable class and adding an array of .cables to Span. In which case, Span could represent a duct. However, that would be a major change and would introduce quite a lot of complexity so I think we need to understand more about the use cases before deciding on modelling.

@duncandewhurst
Copy link
Collaborator

Noting that if we did want to model ducts in detail, we'd need to consider that ducts can be nested as described on the Wikipedia page for microducts.

image

@stevesong
Copy link
Contributor

We are still waiting to hear more detail from the stakeholder. Their interest was in knowing what ISO standard duct the fibre was deployed in. The purpose I believe is to understand whether there is capacity for additional fibre but I am not sure.

@duncandewhurst
Copy link
Collaborator

Thanks for the clarification! With that use case in mind, we might consider a more general field to indicate whether capacity for additional fibre is available, similar to Span.darkFibre and Node.power. If there is a need for more detail, such a field could be paired with a xDetails field. Anyway, we can wait for more information before making any decisions - just logging thoughts whilst they occur to me.

@duncandewhurst duncandewhurst added this to the 0.3.0 milestone Jan 30, 2023
@lgs85
Copy link
Contributor Author

lgs85 commented Jan 31, 2023

Thanks both. Noting here that the thing I think we need to be super clear on is what constitutes a single span vs multiple spans on a similar/the same route. A structural change to the data model can address this explicitly, whereas if we opt for the simpler approach of adding fields we'll need to think carefully about descriptions and definitions.

@duncandewhurst duncandewhurst removed this from the 0.3.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants