Optional List Inconsistencies

[evanspearman-a]

Description

There are some cases where the 2023-09 specification specifies an optional list but does not specify that if specified that the list must contain at least one element. This should be the case for all optional lists for consistency.

Similarly, there are some cases where the 2023-09 specification specifies that a list must contain at least one elements if present, but the list is not optional. In these cases, either the wording should be changed or the list should be made optional, depending on the original intention.

List of occurrences:

• https://github.com/OpenJobDescription/openjd-specifications/wiki/2023-09-Template-Schemas#34-stepparameterspacedefinition (taskParameterDefinitions) - In this case, the field is not optional in the Python implementation of the model and does indeed have a minimum length of 1, so the wording should be changed to remove the "If provided, then"
• https://github.com/OpenJobDescription/openjd-specifications/wiki/2023-09-Template-Schemas#11-job-template (jobEnvironments) - Optional list that does not explicitly disallow empty lists if a list is provided
• https://github.com/OpenJobDescription/openjd-specifications/wiki/2023-09-Template-Schemas#5-action (args) - Optional list that does not explicitly disallow empty lists if a list is provided
• https://github.com/OpenJobDescription/openjd-specifications/wiki/2023-09-Template-Schemas#33-hostrequirements (ammounts, attributes) - Optional list that does not explicitly disallow empty lists if a list is provided
• https://github.com/OpenJobDescription/openjd-specifications/wiki/2023-09-Template-Schemas#21-jobstringparameterdefinition (allowedValues) - Optional list that does not explicitly disallow empty lists if a list is provided
• https://github.com/OpenJobDescription/openjd-specifications/wiki/2023-09-Template-Schemas#22-jobpathparameterdefinition (allowedValues, fileFilters) - Optional list that does not explicitly disallow empty lists if a list is provided
• https://github.com/OpenJobDescription/openjd-specifications/wiki/2023-09-Template-Schemas#23-jobintparameterdefinition (allowedValues) - Optional list that does not explicitly disallow empty lists if a list is provided
• https://github.com/OpenJobDescription/openjd-specifications/wiki/2023-09-Template-Schemas#24-jobfloatparameterdefinition (allowedValues) - Optional list that does not explicitly disallow empty lists if a list is provided
• https://github.com/OpenJobDescription/openjd-specifications/wiki/2023-09-Template-Schemas#11-job-template (steps) - steps should also never be empty.

[evanspearman-a]

Verified that all of these are already enforced in the Python model:

• https://github.com/OpenJobDescription/openjd-model-for-python/blob/mainline/src/openjd/model/v2023_09/_model.py#L2170
• https://github.com/OpenJobDescription/openjd-model-for-python/blob/mainline/src/openjd/model/v2023_09/_model.py#L251
• https://github.com/OpenJobDescription/openjd-model-for-python/blob/mainline/src/openjd/model/v2023_09/_model.py#L2022
• https://github.com/OpenJobDescription/openjd-model-for-python/blob/mainline/src/openjd/model/v2023_09/_model.py#L2032
• https://github.com/OpenJobDescription/openjd-model-for-python/blob/mainline/src/openjd/model/v2023_09/_model.py#L929
• https://github.com/OpenJobDescription/openjd-model-for-python/blob/mainline/src/openjd/model/v2023_09/_model.py#L2167