From 5ccd6859d953588c5c9af445795d57ddbf20231f Mon Sep 17 00:00:00 2001 From: Mihajlo Pavlovic Date: Mon, 9 Dec 2024 17:29:18 +0100 Subject: [PATCH 01/12] port fixes --- .../blockchain-event-listener-command.js | 22 ++++++++++++++----- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/commands/blockchain-event-listener/blockchain-event-listener-command.js b/src/commands/blockchain-event-listener/blockchain-event-listener-command.js index 79da90190..974a2a4e0 100644 --- a/src/commands/blockchain-event-listener/blockchain-event-listener-command.js +++ b/src/commands/blockchain-event-listener/blockchain-event-listener-command.js @@ -477,11 +477,21 @@ class BlockchainEventListenerCommand extends Command { const operationId = await this.operationIdService.generateOperationId( OPERATION_ID_STATUS.PUBLISH_FINALIZATION.PUBLISH_FINALIZATION_START, ); + let datasetPath; + let cachedData; + try { + datasetPath = this.fileService.getPendingStorageDocumentPath(publishOperationId); - const datasetPath = this.fileService.getPendingStorageDocumentPath(publishOperationId); - - const data = await this.fileService.readFile(datasetPath, true); - + cachedData = await this.fileService.readFile(datasetPath, true); + } catch (error) { + this.operationIdService.updateOperationIdStatus( + operationId, + blockchain, + OPERATION_ID_STATUS.FAILED, + error.message, + ERROR_TYPE.FINALITY.FINALITY_ERROR, + ); + } const ual = this.ualService.deriveUAL(blockchain, assetContract, tokenId); await this.commandExecutor.add({ @@ -495,8 +505,8 @@ class BlockchainEventListenerCommand extends Command { contract: assetContract, tokenId, merkleRoot: state, - assertion: data.assertion, - cachedMerkleRoot: data.merkleRoot, + assertion: cachedData.assertion, + cachedMerkleRoot: cachedData.merkleRoot, }, transactional: false, }); From e935e722ace309450d11f5a82972c3444cf86556 Mon Sep 17 00:00:00 2001 From: Mihajlo Pavlovic Date: Mon, 9 Dec 2024 17:30:11 +0100 Subject: [PATCH 02/12] version bump --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 58b014139..24aab0d62 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "origintrail_node", - "version": "8.0.0-beta.8", + "version": "8.0.0-beta.9", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "origintrail_node", - "version": "8.0.0-beta.8", + "version": "8.0.0-beta.9", "license": "ISC", "dependencies": { "@comunica/query-sparql": "^2.4.3", diff --git a/package.json b/package.json index 0b551d41a..adbb59157 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "origintrail_node", - "version": "8.0.0-beta.8", + "version": "8.0.0-beta.9", "description": "OTNode V8", "main": "index.js", "type": "module", From b20fbd316b1680f32b8d5377f65a15c6e7185b0d Mon Sep 17 00:00:00 2001 From: Mihajlo Pavlovic Date: Mon, 9 Dec 2024 17:00:26 +0100 Subject: [PATCH 03/12] Emit status as error type PROTOCOL-NAME_ERROR --- src/service/operation-id-service.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/service/operation-id-service.js b/src/service/operation-id-service.js index 832ebf5ed..94a40d417 100644 --- a/src/service/operation-id-service.js +++ b/src/service/operation-id-service.js @@ -72,8 +72,11 @@ class OperationIdService { await this.removeOperationIdCache(operationId); } - this.emitChangeEvent(status, operationId, blockchain, errorMessage, errorType); - + if (errorType) { + this.emitChangeEvent(errorType, operationId, blockchain, errorMessage, errorType); + } else { + this.emitChangeEvent(status, operationId, blockchain, errorMessage, errorType); + } await this.repositoryModuleManager.updateOperationIdRecord(response, operationId); } From c7bf3752fe42fde24fa6591e935b15dd22af7107 Mon Sep 17 00:00:00 2001 From: Uladzislau Hubar <71610423+u-hubar@users.noreply.github.com> Date: Fri, 13 Dec 2024 12:42:50 +0100 Subject: [PATCH 04/12] Update src/commands/protocols/update/sender/update-validate-asset-command.js Co-authored-by: Marko Brkic --- .../protocols/update/sender/update-validate-asset-command.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/commands/protocols/update/sender/update-validate-asset-command.js b/src/commands/protocols/update/sender/update-validate-asset-command.js index 3272b82cf..5f349eb34 100644 --- a/src/commands/protocols/update/sender/update-validate-asset-command.js +++ b/src/commands/protocols/update/sender/update-validate-asset-command.js @@ -47,7 +47,7 @@ class UpdateValidateAssetCommand extends ValidateAssetCommand { operationId, blockchain, ); - this.validationService.validateDatasetRoot(cachedData.dataset, datasetRoot); + await this.validationService.validateDatasetRoot(cachedData.dataset, datasetRoot); this.operationIdService.emitChangeEvent( OPERATION_ID_STATUS.UPDATE.UPDATE_VALIDATE_DATASET_ROOT_END, operationId, From 4997a954167f30f57ce12d3e79b3a634bc95dd2e Mon Sep 17 00:00:00 2001 From: Uladzislau Hubar <71610423+u-hubar@users.noreply.github.com> Date: Fri, 13 Dec 2024 12:43:00 +0100 Subject: [PATCH 05/12] Update src/controllers/http-api/v1/finality-http-api-controller-v1.js Co-authored-by: Marko Brkic --- src/controllers/http-api/v1/finality-http-api-controller-v1.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/controllers/http-api/v1/finality-http-api-controller-v1.js b/src/controllers/http-api/v1/finality-http-api-controller-v1.js index 65336125c..910e3c46f 100644 --- a/src/controllers/http-api/v1/finality-http-api-controller-v1.js +++ b/src/controllers/http-api/v1/finality-http-api-controller-v1.js @@ -15,7 +15,7 @@ class FinalityController extends BaseController { const { ual } = req.query; const finality = await this.repositoryModuleManager.getFinalityAcksCount(ual || ''); - console.log(finality); + if (typeof finality !== 'number') return this.returnResponse(res, 400, { From 2575d5fcb24800304f48442cb70c6a4878e4de0d Mon Sep 17 00:00:00 2001 From: Uladzislau Hubar Date: Fri, 13 Dec 2024 17:13:55 +0100 Subject: [PATCH 06/12] Updated dkg-evm-module, added byte size validation --- package-lock.json | 14 ++--- package.json | 2 +- .../blockchain-event-listener-command.js | 3 +- ...ish-validate-assertion-metadata-command.js | 55 +++++++++++++++++++ src/constants/constants.js | 2 +- src/service/data-service.js | 4 ++ 6 files changed, 70 insertions(+), 10 deletions(-) diff --git a/package-lock.json b/package-lock.json index a4ac6eb8f..33a4846ef 100644 --- a/package-lock.json +++ b/package-lock.json @@ -26,7 +26,7 @@ "axios": "^1.6.0", "cors": "^2.8.5", "deep-extend": "^0.6.0", - "dkg-evm-module": "^8.0.3-gamma.7", + "dkg-evm-module": "^8.0.3-gamma.8", "dotenv": "^16.0.1", "ethers": "^5.7.2", "express": "^4.18.1", @@ -9062,9 +9062,9 @@ } }, "node_modules/dkg-evm-module": { - "version": "8.0.3-gamma.7", - "resolved": "https://registry.npmjs.org/dkg-evm-module/-/dkg-evm-module-8.0.3-gamma.7.tgz", - "integrity": "sha512-cEjPz8c6vqwhsYiDx5ibIJ0xh9BZDvqtYHigaYf4gE26QaFJs6+NFFoQOSwwbaKmB7FKlSPHw0mOJASqVaWwbw==", + "version": "8.0.3-gamma.8", + "resolved": "https://registry.npmjs.org/dkg-evm-module/-/dkg-evm-module-8.0.3-gamma.8.tgz", + "integrity": "sha512-splfWS1kHMXt0B20B6pXnniE7cT+8x1kmhibBXhDLBQuO32l5yAZrfxoD3v6CUUBY6Au2Nin1BPUHKy1s6CqVA==", "license": "Apache-2.0", "dependencies": { "@openzeppelin/contracts": "^4.9.3", @@ -30092,9 +30092,9 @@ "integrity": "sha512-58lmxKSA4BNyLz+HHMUzlOEpg09FV+ev6ZMe3vJihgdxzgcwZ8VoEEPmALCZG9LmqfVoNMMKpttIYTVG6uDY7A==" }, "dkg-evm-module": { - "version": "8.0.3-gamma.7", - "resolved": "https://registry.npmjs.org/dkg-evm-module/-/dkg-evm-module-8.0.3-gamma.7.tgz", - "integrity": "sha512-cEjPz8c6vqwhsYiDx5ibIJ0xh9BZDvqtYHigaYf4gE26QaFJs6+NFFoQOSwwbaKmB7FKlSPHw0mOJASqVaWwbw==", + "version": "8.0.3-gamma.8", + "resolved": "https://registry.npmjs.org/dkg-evm-module/-/dkg-evm-module-8.0.3-gamma.8.tgz", + "integrity": "sha512-splfWS1kHMXt0B20B6pXnniE7cT+8x1kmhibBXhDLBQuO32l5yAZrfxoD3v6CUUBY6Au2Nin1BPUHKy1s6CqVA==", "requires": { "@openzeppelin/contracts": "^4.9.3", "@polkadot/api": "^11.0.3", diff --git a/package.json b/package.json index ebed6da5e..7e8bd8ab9 100644 --- a/package.json +++ b/package.json @@ -81,7 +81,7 @@ "axios": "^1.6.0", "cors": "^2.8.5", "deep-extend": "^0.6.0", - "dkg-evm-module": "^8.0.3-gamma.7", + "dkg-evm-module": "^8.0.3-gamma.8", "dotenv": "^16.0.1", "ethers": "^5.7.2", "express": "^4.18.1", diff --git a/src/commands/blockchain-event-listener/blockchain-event-listener-command.js b/src/commands/blockchain-event-listener/blockchain-event-listener-command.js index 3a49b5709..e55ae945a 100644 --- a/src/commands/blockchain-event-listener/blockchain-event-listener-command.js +++ b/src/commands/blockchain-event-listener/blockchain-event-listener-command.js @@ -471,7 +471,7 @@ class BlockchainEventListenerCommand extends Command { async handleKnowledgeCollectionCreatedEvent(event) { const eventData = JSON.parse(event.data); - const { id, merkleRoot, publishOperationId } = eventData; + const { id, publishOperationId, merkleRoot, chunksAmount } = eventData; const { blockchain, contractAddress } = event; const operationId = await this.operationIdService.generateOperationId( @@ -519,6 +519,7 @@ class BlockchainEventListenerCommand extends Command { contract: contractAddress, tokenId: id, merkleRoot, + chunksAmount, remotePeerId: cachedData.remotePeerId, publishOperationId, assertion: cachedData.assertion, diff --git a/src/commands/protocols/publish/publish-validate-assertion-metadata-command.js b/src/commands/protocols/publish/publish-validate-assertion-metadata-command.js index 306669aaf..7d63e6cb0 100644 --- a/src/commands/protocols/publish/publish-validate-assertion-metadata-command.js +++ b/src/commands/protocols/publish/publish-validate-assertion-metadata-command.js @@ -1,10 +1,12 @@ import ValidateAssertionMetadataCommand from '../common/validate-assertion-metadata-command.js'; import { OPERATION_ID_STATUS, ERROR_TYPE } from '../../../constants/constants.js'; +import Command from '../../command.js'; class PublishValidateAssertionMetadataCommand extends ValidateAssertionMetadataCommand { constructor(ctx) { super(ctx); this.operationIdService = ctx.operationIdService; + this.dataService = ctx.dataService; this.errorType = ERROR_TYPE.PUBLISH.PUBLISH_VALIDATE_ASSERTION_METADATA_ERROR; this.operationStartEvent = @@ -13,6 +15,59 @@ class PublishValidateAssertionMetadataCommand extends ValidateAssertionMetadataC OPERATION_ID_STATUS.PUBLISH_FINALIZATION.PUBLISH_FINALIZATION_METADATA_VALIDATION_END; } + async execute(command) { + const { + operationId, + ual, + blockchain, + assertion, + merkleRoot, + cachedMerkleRoot, + chunksAmount, + } = command.data; + + await this.operationIdService.updateOperationIdStatus( + operationId, + blockchain, + this.operationStartEvent, + ); + + try { + if (merkleRoot !== cachedMerkleRoot) { + await this.handleError( + operationId, + blockchain, + `Invalid Merkle Root for Knowledge Collection with UAL: ${ual}. Received value from blockchain: ${merkleRoot}, Cached value from publish operation: ${cachedMerkleRoot}`, + this.errorType, + true, + ); + + const calculatedChunksAmount = this.dataService.calculateChunksAmount(assertion); + + if (chunksAmount !== calculatedChunksAmount) { + await this.handleError( + operationId, + blockchain, + `Invalid Chunks Amount for Knowledge Collection with UAL: ${ual}. Received value from blockchain: ${chunksAmount}, Calculated value: ${calculatedChunksAmount}`, + this.errorType, + true, + ); + } + } + } catch (e) { + await this.handleError(operationId, blockchain, e.message, this.errorType, true); + return Command.empty(); + } + + await this.operationIdService.updateOperationIdStatus( + operationId, + blockchain, + this.operationEndEvent, + ); + + return this.continueSequence(command.data, command.sequence); + } + /** * Builds default publishValidateAssertionMetadataCommand * @param map diff --git a/src/constants/constants.js b/src/constants/constants.js index 1c64dbd46..77aa55edc 100644 --- a/src/constants/constants.js +++ b/src/constants/constants.js @@ -247,7 +247,7 @@ const require = createRequire(import.meta.url); export const ABIs = { KnowledgeCollection: require('dkg-evm-module/abi/KnowledgeCollection.json'), - KnowledgeCollectionStorage: require('dkg-evm-module/abi/KnowledgeCollectionLib.json'), + KnowledgeCollectionStorage: require('dkg-evm-module/abi/KnowledgeCollectionStorage.json'), Staking: require('dkg-evm-module/abi/Staking.json'), Token: require('dkg-evm-module/abi/Token.json'), Hub: require('dkg-evm-module/abi/Hub.json'), diff --git a/src/service/data-service.js b/src/service/data-service.js index 0e1a8c903..bd1fb044a 100644 --- a/src/service/data-service.js +++ b/src/service/data-service.js @@ -13,6 +13,10 @@ class DataService { this.cryptoService = ctx.cryptoService; } + calculateChunksAmount(assertion) { + return kcTools.calculateNumberOfChunks(assertion); + } + createTripleAnnotations(groupedTriples, annotationPredicate, annotations) { return groupedTriples.flatMap((knowledgeAssetTriples, index) => knowledgeAssetTriples.map( From ba5abd0a933a157636b6aef7ec3f72959f516abb Mon Sep 17 00:00:00 2001 From: Mihajlo Pavlovic Date: Sun, 15 Dec 2024 11:42:58 +0100 Subject: [PATCH 07/12] Update devnet hub --- config/config.json | 13 ++++++------- package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/config/config.json b/config/config.json index b9a156aa5..0bca886f0 100644 --- a/config/config.json +++ b/config/config.json @@ -158,7 +158,7 @@ "localEndpoint": "http::addr=localhost:10000", "signalingServiceEndpoint": "", "sendToSignalingService": false - } + } } } }, @@ -347,7 +347,7 @@ "localEndpoint": "http::addr=localhost:10000", "signalingServiceEndpoint": "", "sendToSignalingService": false - } + } } } }, @@ -536,7 +536,7 @@ "localEndpoint": "http::addr=localhost:10000", "signalingServiceEndpoint": "", "sendToSignalingService": false - } + } } } }, @@ -675,7 +675,7 @@ "package": "./blockchain/implementation/base/base-service.js", "config": { - "hubContractAddress": "0xAB4A4794Fc1F415C24807B947280aCa8dC492238", + "hubContractAddress": "0x3e5dd82e7529F4e55AA64893D8f8879AE14BF87D", "rpcEndpoints": ["https://sepolia.base.org"], "operatorFee": 0 } @@ -722,7 +722,7 @@ "localEndpoint": "http::addr=localhost:10000", "signalingServiceEndpoint": "", "sendToSignalingService": false - } + } } } }, @@ -931,8 +931,7 @@ "localEndpoint": "http::addr=localhost:10000", "signalingServiceEndpoint": "", "sendToSignalingService": false - - } + } } } }, diff --git a/package-lock.json b/package-lock.json index 33a4846ef..01fe401b3 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "origintrail_node", - "version": "8.0.0-gamma.0", + "version": "8.0.0-gamma.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "origintrail_node", - "version": "8.0.0-gamma.0", + "version": "8.0.0-gamma.1", "license": "ISC", "dependencies": { "@comunica/query-sparql": "^2.4.3", diff --git a/package.json b/package.json index 7e8bd8ab9..c3f40c510 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "origintrail_node", - "version": "8.0.0-gamma.0", + "version": "8.0.0-gamma.1", "description": "OTNode V8", "main": "index.js", "type": "module", From becd9af726c6da45fa36ae9bef802e762b318a34 Mon Sep 17 00:00:00 2001 From: Mihajlo Pavlovic Date: Sun, 15 Dec 2024 14:01:06 +0100 Subject: [PATCH 08/12] Comment out telemetry event sent log --- src/modules/telemetry/implementation/quest-telemetry.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/telemetry/implementation/quest-telemetry.js b/src/modules/telemetry/implementation/quest-telemetry.js index 13ae80192..13faf4fab 100644 --- a/src/modules/telemetry/implementation/quest-telemetry.js +++ b/src/modules/telemetry/implementation/quest-telemetry.js @@ -38,7 +38,7 @@ class QuestTelemetry { await this.localSender.flush(); await this.localSender.close(); - this.logger.info('Event telemetry successfully sent to local QuestDB'); + // this.logger.info('Event telemetry successfully sent to local QuestDB'); } catch (err) { this.logger.error(`Error sending telemetry to local QuestDB: ${err.message}`); } From 51efb215b5d9bc56e2433f0c2cafa46f1c67aba3 Mon Sep 17 00:00:00 2001 From: Mihajlo Pavlovic Date: Sun, 15 Dec 2024 15:37:35 +0100 Subject: [PATCH 09/12] Fixes for event lisnter --- .../blockchain-event-listener-command.js | 15 +++++++-------- .../implementation/ot-ethers/ot-ethers.js | 12 +++++++++--- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/src/commands/blockchain-event-listener/blockchain-event-listener-command.js b/src/commands/blockchain-event-listener/blockchain-event-listener-command.js index c1fcee889..bbb8670d4 100644 --- a/src/commands/blockchain-event-listener/blockchain-event-listener-command.js +++ b/src/commands/blockchain-event-listener/blockchain-event-listener-command.js @@ -76,14 +76,15 @@ class BlockchainEventListenerCommand extends Command { await this.repositoryModuleManager.insertBlockchainEvents(newEvents, { transaction: repositoryTransaction, }); - await this.repositoryModuleManager.updateLastCheckedBlock( - blockchainId, - this.currentBlock, - Date.now(), - { transaction: repositoryTransaction }, - ); } + await this.repositoryModuleManager.updateLastCheckedBlock( + blockchainId, + this.currentBlock, + Date.now(), + { transaction: repositoryTransaction }, + ); + const unprocessedEvents = await this.repositoryModuleManager.getAllUnprocessedBlockchainEvents( blockchainId, @@ -470,10 +471,8 @@ class BlockchainEventListenerCommand extends Command { async handleKnowledgeCollectionCreatedEvent(event) { const eventData = JSON.parse(event.data); - const { id, publishOperationId, merkleRoot, chunksAmount } = eventData; const { blockchain, contractAddress } = event; - const operationId = await this.operationIdService.generateOperationId( OPERATION_ID_STATUS.PUBLISH_FINALIZATION.PUBLISH_FINALIZATION_START, publishOperationId, diff --git a/src/modules/blockchain-events/implementation/ot-ethers/ot-ethers.js b/src/modules/blockchain-events/implementation/ot-ethers/ot-ethers.js index ca40db542..acf9c4f87 100644 --- a/src/modules/blockchain-events/implementation/ot-ethers/ot-ethers.js +++ b/src/modules/blockchain-events/implementation/ot-ethers/ot-ethers.js @@ -122,7 +122,6 @@ class OtEthers extends BlockchainEventsService { let fromBlock = currentBlock - lastCheckedBlock > maxBlocksToSync ? currentBlock : lastCheckedBlock + 1; const eventsMissed = currentBlock - lastCheckedBlock > maxBlocksToSync; - if (eventsMissed) { return { events: [], @@ -168,12 +167,19 @@ class OtEthers extends BlockchainEventsService { fromBlock + MAXIMUM_NUMBERS_OF_BLOCKS_TO_FETCH - 1, currentBlock, ); + + const fromBlockParam = ethers.BigNumber.from(fromBlock) + .toHexString() + .replace(/^0x0+/, '0x'); + const toBlockParam = ethers.BigNumber.from(toBlock) + .toHexString() + .replace(/^0x0+/, '0x'); const provider = this._getRandomProvider(blockchain); const newLogs = await provider.send('eth_getLogs', [ { address: contractAddresses, - fromBlock: ethers.BigNumber.from(fromBlock).toHexString(), - toBlock: ethers.BigNumber.from(toBlock).toHexString(), + fromBlock: fromBlockParam, + toBlock: toBlockParam, topics: [topics], }, ]); From 18797b8bc5446e29b8d68967f52828b96cd6d6cc Mon Sep 17 00:00:00 2001 From: Mihajlo Pavlovic Date: Sun, 15 Dec 2024 15:38:12 +0100 Subject: [PATCH 10/12] version bump --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 01fe401b3..5de4a9658 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "origintrail_node", - "version": "8.0.0-gamma.1", + "version": "8.0.0-gamma.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "origintrail_node", - "version": "8.0.0-gamma.1", + "version": "8.0.0-gamma.2", "license": "ISC", "dependencies": { "@comunica/query-sparql": "^2.4.3", diff --git a/package.json b/package.json index c3f40c510..323a38726 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "origintrail_node", - "version": "8.0.0-gamma.1", + "version": "8.0.0-gamma.2", "description": "OTNode V8", "main": "index.js", "type": "module", From 7663abdb428623d051c23089ca319039750ec9d7 Mon Sep 17 00:00:00 2001 From: Mihajlo Pavlovic Date: Sun, 15 Dec 2024 16:23:29 +0100 Subject: [PATCH 11/12] Change hub for event listner --- config/config.json | 2 +- package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/config.json b/config/config.json index 0bca886f0..8d0e9f689 100644 --- a/config/config.json +++ b/config/config.json @@ -738,7 +738,7 @@ "base:84532": ["https://sepolia.base.org"] }, "hubContractAddress": { - "base:84532": "0xAB4A4794Fc1F415C24807B947280aCa8dC492238" + "base:84532": "0x3e5dd82e7529F4e55AA64893D8f8879AE14BF87D" } } } diff --git a/package-lock.json b/package-lock.json index 5de4a9658..fbd691a67 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "origintrail_node", - "version": "8.0.0-gamma.2", + "version": "8.0.0-gamma.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "origintrail_node", - "version": "8.0.0-gamma.2", + "version": "8.0.0-gamma.3", "license": "ISC", "dependencies": { "@comunica/query-sparql": "^2.4.3", diff --git a/package.json b/package.json index 323a38726..be0a95d25 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "origintrail_node", - "version": "8.0.0-gamma.2", + "version": "8.0.0-gamma.3", "description": "OTNode V8", "main": "index.js", "type": "module", From 906d61963d8e83ab7ca8ac81087f5a873d662b81 Mon Sep 17 00:00:00 2001 From: Mihajlo Pavlovic Date: Sun, 15 Dec 2024 16:53:32 +0100 Subject: [PATCH 12/12] Add todo for validateDatasetOnBlockchain --- src/service/validation-service.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/service/validation-service.js b/src/service/validation-service.js index e844987f9..743d49c4b 100644 --- a/src/service/validation-service.js +++ b/src/service/validation-service.js @@ -39,7 +39,7 @@ class ValidationService { } async validateDatasetRootOnBlockchain(knowledgeCollectionId, assertionId, blockchain) { - // call contract TO DO, dont return anything or return true + // TODO: call contract TO DO, dont return anything or return true return { knowledgeCollectionId, assertionId, blockchain }; }