Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the way we add Generic Elements #156

Open
Castone22 opened this issue Jul 2, 2019 · 0 comments
Open

Refine the way we add Generic Elements #156

Castone22 opened this issue Jul 2, 2019 · 0 comments

Comments

@Castone22
Copy link
Contributor

Castone22 commented Jul 2, 2019

Currently there's room for confusion with the way the generic elements get created that @greenarrowdb raised.

I think i'm going to add a add_generic_element method that defaults to a CoreElement for creating elements that are meant to be used as parents or base elements for location.

I'll probably add a warning to add_element if it's called without an element type the first time the code point is hit per page (as as not to log spam)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant