Enable passing the base path to Problem.from_yaml #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing the problem configuration as `dict` to `Problem.from_yaml`, one should be able to specify the base path for resolving relative paths. See PEtab-dev#324. Closes PEtab-dev#324
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #327 +/- ##
===========================================
+ Coverage 72.79% 74.92% +2.12%
===========================================
Files 52 52
Lines 4907 4913 +6
Branches 841 845 +4
===========================================
+ Hits 3572 3681 +109
+ Misses 1028 923 -105
- Partials 307 309 +2 ☔ View full report in Codecov by Sentry. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing the problem configuration as
dicttoProblem.from_yaml, one should be able to specify the base path for resolving relative paths. See #324.Closes #324