Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: appending a DocumentFragment returns false if fragment is empty #458

Open
g105b opened this issue Jan 9, 2025 · 0 comments
Open

Bug: appending a DocumentFragment returns false if fragment is empty #458

g105b opened this issue Jan 9, 2025 · 0 comments
Labels
bug Something isn't working as expected good first issue Good for newcomers

Comments

@g105b
Copy link
Member

g105b commented Jan 9, 2025

This isn't how it works in the browser, so this is a bug with the underlying return value of appendChild.

If a DocumentFragment has no childNodes, and it's appended to another element, the call to DOMElement::appendChild returns false, when it should actually return the appended DocumentFragment.
@g105b g105b added bug Something isn't working as expected good first issue Good for newcomers labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@g105b