Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic: Line numbers are off by a couple when using plain PHP file as page logic #62

Open
g105b opened this issue Nov 26, 2024 · 0 comments
Open

Logic: Line numbers are off by a couple when using plain PHP file as page logic #62

g105b opened this issue Nov 26, 2024 · 0 comments
Assignees
@g105b
Labels
enhancement New feature or request

Comments

@g105b
Copy link
Member

g105b commented Nov 26, 2024

Because we use the logic stream wrapper, and we wrap the functions in a class, we're actually shifting the line numbers by a couple of lines. The class should really be added on the same line as the opening PHP tags to avoid this.
@g105b g105b added the enhancement New feature or request label Nov 26, 2024
@g105b g105b self-assigned this Nov 26, 2024
@g105b g105b transferred this issue from PhpGt/WebEngine Nov 26, 2024
g105b added a commit that referenced this issue Nov 26, 2024
@g105b
fix: add a tab instead of newlines
79ac35a 
closes #62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g105b g105b

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@g105b