You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dbt-score doesn't properly handle manifest.json files that contain invalid JSON.
Steps to reproduce:
Create a directory, e.g. example_dbt_project, and a target directory within that directory.
Create a manifest.json file containing invalid JSON (e.g. an empty file) in the target directory.
cd into example_dbt_project and run dbt-score lint.
Expected behavior: dbt-score detects that the manifest file is invalid and handles it gracefully, e.g. by writing an error message about the manifest being invalid and exiting.
Actual behavior: dbt-score raises an exception from within json.decoder library (e.g. json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)).
The text was updated successfully, but these errors were encountered:
Hi @nick-kogan, thanks for reporting this issue!
Given dbt-score merely forwards the exception raised somewhere else (e.g. in dbt's library), isn't it best to show it to users?
dbt-score
doesn't properly handlemanifest.json
files that contain invalid JSON.Steps to reproduce:
example_dbt_project
, and atarget
directory within that directory.manifest.json
file containing invalid JSON (e.g. an empty file) in thetarget
directory.cd
intoexample_dbt_project
and rundbt-score lint
.Expected behavior:
dbt-score
detects that the manifest file is invalid and handles it gracefully, e.g. by writing an error message about the manifest being invalid and exiting.Actual behavior:
dbt-score
raises an exception from withinjson.decoder
library (e.g.json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
).The text was updated successfully, but these errors were encountered: