From db265e28a76b3128425502353612ed5b6c609a96 Mon Sep 17 00:00:00 2001 From: Harrison Hassig Date: Thu, 9 Jan 2025 08:14:42 +0100 Subject: [PATCH 01/11] Gemfile and version change --- .github/workflows/test.yml | 4 +- .ruby-version | 1 + Gemfile | 4 +- Gemfile.lock | 895 +++++++++++----------- app/cells/decidim/notify/chapter/show.erb | 2 +- app/cells/decidim/notify/note/show.erb | 2 +- lib/decidim/notify/version.rb | 4 +- package.json | 3 +- test.txt | 239 ++++++ 9 files changed, 713 insertions(+), 441 deletions(-) create mode 100644 .ruby-version create mode 100644 test.txt diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1ccf36e..89510bf 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,11 +7,11 @@ on: pull_request: env: - RUBY_VERSION: 3.0.2 + RUBY_VERSION: 3.1.1 jobs: test: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 services: postgres: image: postgres:11 diff --git a/.ruby-version b/.ruby-version new file mode 100644 index 0000000..94ff29c --- /dev/null +++ b/.ruby-version @@ -0,0 +1 @@ +3.1.1 diff --git a/Gemfile b/Gemfile index c414a07..66fc743 100644 --- a/Gemfile +++ b/Gemfile @@ -4,7 +4,7 @@ source "https://rubygems.org" ruby RUBY_VERSION -DECIDIM_VERSION = "0.27" +DECIDIM_VERSION = "0.28" gem "decidim", DECIDIM_VERSION gem "decidim-notify", path: "." @@ -14,7 +14,7 @@ gem "bootsnap", "~> 1.4" gem "puma", ">= 5.0.0" gem "uglifier", "~> 4.1" -gem "faker", "~> 2.14" +gem "faker" group :development, :test do gem "byebug", "~> 11.0", platform: :mri diff --git a/Gemfile.lock b/Gemfile.lock index 414e3a0..9e62341 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,47 +1,47 @@ PATH remote: . specs: - decidim-notify (0.6) - decidim-admin (>= 0.27.0, < 0.28) - decidim-core (>= 0.27.0, < 0.28) + decidim-notify (0.7) + decidim-admin (>= 0.28.0, < 0.29) + decidim-core (>= 0.28.0, < 0.29) GEM remote: https://rubygems.org/ specs: - actioncable (6.1.7.3) - actionpack (= 6.1.7.3) - activesupport (= 6.1.7.3) + actioncable (6.1.7.10) + actionpack (= 6.1.7.10) + activesupport (= 6.1.7.10) nio4r (~> 2.0) websocket-driver (>= 0.6.1) - actionmailbox (6.1.7.3) - actionpack (= 6.1.7.3) - activejob (= 6.1.7.3) - activerecord (= 6.1.7.3) - activestorage (= 6.1.7.3) - activesupport (= 6.1.7.3) + actionmailbox (6.1.7.10) + actionpack (= 6.1.7.10) + activejob (= 6.1.7.10) + activerecord (= 6.1.7.10) + activestorage (= 6.1.7.10) + activesupport (= 6.1.7.10) mail (>= 2.7.1) - actionmailer (6.1.7.3) - actionpack (= 6.1.7.3) - actionview (= 6.1.7.3) - activejob (= 6.1.7.3) - activesupport (= 6.1.7.3) + actionmailer (6.1.7.10) + actionpack (= 6.1.7.10) + actionview (= 6.1.7.10) + activejob (= 6.1.7.10) + activesupport (= 6.1.7.10) mail (~> 2.5, >= 2.5.4) rails-dom-testing (~> 2.0) - actionpack (6.1.7.3) - actionview (= 6.1.7.3) - activesupport (= 6.1.7.3) + actionpack (6.1.7.10) + actionview (= 6.1.7.10) + activesupport (= 6.1.7.10) rack (~> 2.0, >= 2.0.9) rack-test (>= 0.6.3) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.2.0) - actiontext (6.1.7.3) - actionpack (= 6.1.7.3) - activerecord (= 6.1.7.3) - activestorage (= 6.1.7.3) - activesupport (= 6.1.7.3) + actiontext (6.1.7.10) + actionpack (= 6.1.7.10) + activerecord (= 6.1.7.10) + activestorage (= 6.1.7.10) + activesupport (= 6.1.7.10) nokogiri (>= 1.8.5) - actionview (6.1.7.3) - activesupport (= 6.1.7.3) + actionview (6.1.7.10) + activesupport (= 6.1.7.10) builder (~> 3.1) erubi (~> 1.4) rails-dom-testing (~> 2.0) @@ -49,69 +49,63 @@ GEM active_link_to (1.0.5) actionpack addressable - activejob (6.1.7.3) - activesupport (= 6.1.7.3) + activejob (6.1.7.10) + activesupport (= 6.1.7.10) globalid (>= 0.3.6) - activemodel (6.1.7.3) - activesupport (= 6.1.7.3) - activerecord (6.1.7.3) - activemodel (= 6.1.7.3) - activesupport (= 6.1.7.3) - activestorage (6.1.7.3) - actionpack (= 6.1.7.3) - activejob (= 6.1.7.3) - activerecord (= 6.1.7.3) - activesupport (= 6.1.7.3) + activemodel (6.1.7.10) + activesupport (= 6.1.7.10) + activerecord (6.1.7.10) + activemodel (= 6.1.7.10) + activesupport (= 6.1.7.10) + activestorage (6.1.7.10) + actionpack (= 6.1.7.10) + activejob (= 6.1.7.10) + activerecord (= 6.1.7.10) + activesupport (= 6.1.7.10) marcel (~> 1.0) mini_mime (>= 1.1.0) - activesupport (6.1.7.3) + activesupport (6.1.7.10) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 1.6, < 2) minitest (>= 5.1) tzinfo (~> 2.0) zeitwerk (~> 2.3) - acts_as_list (0.9.19) - activerecord (>= 3.0) - addressable (2.8.4) - public_suffix (>= 2.0.2, < 6.0) + acts_as_list (1.2.4) + activerecord (>= 6.1) + activesupport (>= 6.1) + addressable (2.8.7) + public_suffix (>= 2.0.2, < 7.0) ast (2.4.2) - axe-core-api (4.7.0) - dumb_delegator - virtus - axe-core-rspec (4.1.0) - axe-core-api - dumb_delegator - virtus - axiom-types (0.1.1) - descendants_tracker (~> 0.0.4) - ice_nine (~> 0.11.0) - thread_safe (~> 0.3, >= 0.3.1) + base64 (0.2.0) batch-loader (1.5.0) - bcrypt (3.1.19) - better_html (1.0.16) - actionview (>= 4.0) - activesupport (>= 4.0) + bcrypt (3.1.20) + better_html (2.1.1) + actionview (>= 6.0) + activesupport (>= 6.0) ast (~> 2.0) erubi (~> 1.4) - html_tokenizer (~> 0.0.6) parser (>= 2.4) smart_properties + bigdecimal (3.1.9) bindex (0.8.1) - bootsnap (1.16.0) + bootsnap (1.18.4) msgpack (~> 1.2) browser (2.7.1) - builder (3.2.4) + builder (3.3.0) + bullet (7.2.0) + activesupport (>= 3.0.0) + uniform_notifier (~> 1.11) byebug (11.1.3) - capybara (3.39.2) + capybara (3.40.0) addressable matrix mini_mime (>= 0.1.3) - nokogiri (~> 1.8) + nokogiri (~> 1.11) rack (>= 1.6.0) rack-test (>= 0.6.3) regexp_parser (>= 1.5, < 3.0) xpath (~> 3.2) - carrierwave (2.2.4) + carrierwave (2.2.6) activemodel (>= 5.0.0) activesupport (>= 5.0.0) addressable (~> 2.6) @@ -119,107 +113,98 @@ GEM marcel (~> 1.0.0) mini_mime (>= 0.1.3) ssrf_filter (~> 1.0) - cells (4.1.7) - declarative-builder (< 0.2.0) + cells (4.1.8) + declarative-builder (~> 0.2.0) declarative-option (< 0.2.0) tilt (>= 1.4, < 3) uber (< 0.2.0) cells-erb (0.1.0) cells (~> 4.0) erbse (>= 0.1.1) - cells-rails (0.1.5) + cells-rails (0.1.6) actionpack (>= 5.0) cells (>= 4.1.6, < 5.0.0) - charlock_holmes (0.7.7) - chef-utils (18.2.7) - concurrent-ruby - childprocess (4.1.0) - codecov (0.6.0) - simplecov (>= 0.15, < 0.22) - coercible (1.0.0) - descendants_tracker (~> 0.0.1) - coffee-rails (5.0.0) - coffee-script (>= 2.2.0) - railties (>= 5.2.0) - coffee-script (2.4.1) - coffee-script-source - execjs - coffee-script-source (1.12.2) - commonmarker (0.23.9) - concurrent-ruby (1.2.2) - crack (0.4.5) + charlock_holmes (0.7.9) + childprocess (5.1.0) + logger (~> 1.5) + codecov (0.2.12) + json + simplecov + commonmarker (0.23.11) + concurrent-ruby (1.3.4) + crack (1.0.0) + bigdecimal rexml crass (1.0.6) - css_parser (1.14.0) + css_parser (1.21.0) addressable - date (3.3.3) + csv (3.3.2) + date (3.4.1) date_validator (0.12.0) activemodel (>= 3) activesupport (>= 3) - db-query-matchers (0.10.0) - activesupport (>= 4.0, < 7) - rspec (~> 3.0) - decidim (0.27.0) - decidim-accountability (= 0.27.0) - decidim-admin (= 0.27.0) - decidim-api (= 0.27.0) - decidim-assemblies (= 0.27.0) - decidim-blogs (= 0.27.0) - decidim-budgets (= 0.27.0) - decidim-comments (= 0.27.0) - decidim-core (= 0.27.0) - decidim-debates (= 0.27.0) - decidim-forms (= 0.27.0) - decidim-generators (= 0.27.0) - decidim-meetings (= 0.27.0) - decidim-pages (= 0.27.0) - decidim-participatory_processes (= 0.27.0) - decidim-proposals (= 0.27.0) - decidim-sortitions (= 0.27.0) - decidim-surveys (= 0.27.0) - decidim-system (= 0.27.0) - decidim-templates (= 0.27.0) - decidim-verifications (= 0.27.0) - decidim-accountability (0.27.0) - decidim-comments (= 0.27.0) - decidim-core (= 0.27.0) - decidim-admin (0.27.0) + decidim (0.28.0) + decidim-accountability (= 0.28.0) + decidim-admin (= 0.28.0) + decidim-api (= 0.28.0) + decidim-assemblies (= 0.28.0) + decidim-blogs (= 0.28.0) + decidim-budgets (= 0.28.0) + decidim-comments (= 0.28.0) + decidim-core (= 0.28.0) + decidim-debates (= 0.28.0) + decidim-forms (= 0.28.0) + decidim-generators (= 0.28.0) + decidim-meetings (= 0.28.0) + decidim-pages (= 0.28.0) + decidim-participatory_processes (= 0.28.0) + decidim-proposals (= 0.28.0) + decidim-sortitions (= 0.28.0) + decidim-surveys (= 0.28.0) + decidim-system (= 0.28.0) + decidim-templates (= 0.28.0) + decidim-verifications (= 0.28.0) + decidim-accountability (0.28.0) + decidim-comments (= 0.28.0) + decidim-core (= 0.28.0) + decidim-admin (0.28.0) active_link_to (~> 1.0) - decidim-core (= 0.27.0) + decidim-core (= 0.28.0) devise (~> 4.7) devise-i18n (~> 1.2) - devise_invitable (~> 2.0) - decidim-api (0.27.0) - graphql (~> 1.12, < 1.13) - graphql-docs (~> 2.1.0) + devise_invitable (~> 2.0, >= 2.0.9) + decidim-api (0.28.0) + commonmarker (~> 0.23.0, >= 0.23.9) + graphql (~> 2.0.0) + graphql-docs (~> 3.0.1) rack-cors (~> 1.0) - decidim-assemblies (0.27.0) - decidim-core (= 0.27.0) - decidim-blogs (0.27.0) - decidim-admin (= 0.27.0) - decidim-comments (= 0.27.0) - decidim-core (= 0.27.0) - decidim-budgets (0.27.0) - decidim-comments (= 0.27.0) - decidim-core (= 0.27.0) - decidim-comments (0.27.0) - decidim-core (= 0.27.0) + decidim-assemblies (0.28.0) + decidim-core (= 0.28.0) + decidim-blogs (0.28.0) + decidim-admin (= 0.28.0) + decidim-comments (= 0.28.0) + decidim-core (= 0.28.0) + decidim-budgets (0.28.0) + decidim-comments (= 0.28.0) + decidim-core (= 0.28.0) + decidim-comments (0.28.0) + decidim-core (= 0.28.0) redcarpet (~> 3.5, >= 3.5.1) - decidim-core (0.27.0) + decidim-core (0.28.0) active_link_to (~> 1.0) - acts_as_list (~> 0.9) + acts_as_list (~> 1.0) batch-loader (~> 1.2) browser (~> 2.7) - carrierwave (~> 2.2.1) + carrierwave (~> 2.2.5, >= 2.2.5) cells-erb (~> 0.1.0) cells-rails (~> 0.1.3) charlock_holmes (~> 0.7) date_validator (~> 0.12.0) - decidim-api (= 0.27.0) + decidim-api (= 0.28.0) devise (~> 4.7) - devise-i18n (~> 1.2) + devise-i18n (~> 1.2, < 1.11.1) diffy (~> 3.3) - doorkeeper (~> 5.1) + doorkeeper (~> 5.6, >= 5.6.6) doorkeeper-i18n (~> 4.0) file_validators (~> 3.0) fog-local (~> 0.6) @@ -228,110 +213,110 @@ GEM hashdiff (>= 0.4.0, < 2.0.0) invisible_captcha (~> 0.12) kaminari (~> 1.2, >= 1.2.1) - loofah (~> 2.3.1) + loofah (~> 2.19, >= 2.19.1) mime-types (>= 1.16, < 4.0) mini_magick (~> 4.9) mustache (~> 1.1.0) + net-smtp (~> 0.3.1) omniauth (~> 2.0) omniauth-facebook (~> 5.0) omniauth-google-oauth2 (~> 1.0) omniauth-rails_csrf_protection (~> 1.0) omniauth-twitter (~> 1.4) paper_trail (~> 12.0) - pg (~> 1.1.4, < 2) + pg (~> 1.4.0, < 2) pg_search (~> 2.2) premailer-rails (~> 1.10) - rack (~> 2.2, >= 2.2.3) + psych (~> 4.0) + rack (~> 2.2, >= 2.2.6.4) rack-attack (~> 6.0) - rails (~> 6.1.0) + rails (~> 6.1.7, >= 6.1.7.4) rails-i18n (~> 6.0) - ransack (~> 2.4.1) + ransack (~> 3.2.1) redis (~> 4.1) request_store (~> 1.5.0) rubyXL (~> 3.4) rubyzip (~> 2.0) seven_zip_ruby (~> 1.3) - social-share-button (~> 1.2, >= 1.2.1) - valid_email2 (~> 2.1) - webpacker (= 6.0.0.rc.5) - webpush (~> 1.1) + shakapacker (~> 7.1.0) + valid_email2 (~> 4.0) + web-push (~> 3.0) wisper (~> 2.0) - decidim-debates (0.27.0) - decidim-comments (= 0.27.0) - decidim-core (= 0.27.0) - decidim-dev (0.27.0) - axe-core-rspec (~> 4.1.0) + decidim-debates (0.28.0) + decidim-comments (= 0.28.0) + decidim-core (= 0.28.0) + decidim-dev (0.28.0) + bullet (~> 7.0) byebug (~> 11.0) - capybara (~> 3.24) - db-query-matchers (~> 0.10.0) - decidim (= 0.27.0) - erb_lint (~> 0.0.35) - factory_bot_rails (~> 4.8) - i18n-tasks (~> 0.9.18) - mdl (~> 0.5) - nokogiri (~> 1.13) - parallel_tests (~> 3.7) - puma (~> 5.0) + capybara (~> 3.39) + decidim (= 0.28.0) + erb_lint (~> 0.4.0) + factory_bot_rails (~> 6.2) + faker (~> 3.2) + i18n-tasks (~> 1.0) + nokogiri (~> 1.14, >= 1.14.3) + parallel_tests (~> 4.2) + puma (~> 6.2, >= 6.3.1) rails-controller-testing (~> 1.0) + rspec (~> 3.12) rspec-cells (~> 0.3.7) - rspec-html-matchers (~> 0.9.1) - rspec-rails (~> 4.0) + rspec-html-matchers (~> 0.10) + rspec-rails (~> 6.0) rspec-retry (~> 0.6.2) - rspec_junit_formatter (~> 0.3.0) - rubocop (~> 1.28.0) - rubocop-rails (~> 2.14) - rubocop-rspec (~> 2.10) - selenium-webdriver (~> 4.1.0) - simplecov (~> 0.21.0) + rspec_junit_formatter (~> 0.6.0) + rubocop (~> 1.50.0) + rubocop-faker (~> 1.1) + rubocop-rails (~> 2.19) + rubocop-rspec (~> 2.20) + selenium-webdriver (~> 4.9) + simplecov (~> 0.22.0) simplecov-cobertura (~> 2.1.0) w3c_rspec_validators (~> 0.3.0) - webmock (~> 3.6) + webmock (~> 3.18) wisper-rspec (~> 1.0) - decidim-forms (0.27.0) - decidim-core (= 0.27.0) + decidim-forms (0.28.0) + decidim-core (= 0.28.0) wicked_pdf (~> 2.1) wkhtmltopdf-binary (~> 0.12) - decidim-generators (0.27.0) - decidim-core (= 0.27.0) - decidim-meetings (0.27.0) - decidim-core (= 0.27.0) - decidim-forms (= 0.27.0) + decidim-generators (0.28.0) + decidim-core (= 0.28.0) + decidim-meetings (0.28.0) + decidim-core (= 0.28.0) + decidim-forms (= 0.28.0) icalendar (~> 2.5) - decidim-pages (0.27.0) - decidim-core (= 0.27.0) - decidim-participatory_processes (0.27.0) - decidim-core (= 0.27.0) - decidim-proposals (0.27.0) - decidim-comments (= 0.27.0) - decidim-core (= 0.27.0) - doc2text (~> 0.4.5) + decidim-pages (0.28.0) + decidim-core (= 0.28.0) + decidim-participatory_processes (0.28.0) + decidim-core (= 0.28.0) + decidim-proposals (0.28.0) + decidim-comments (= 0.28.0) + decidim-core (= 0.28.0) + doc2text (~> 0.4.6) redcarpet (~> 3.5, >= 3.5.1) - decidim-sortitions (0.27.0) - decidim-admin (= 0.27.0) - decidim-comments (= 0.27.0) - decidim-core (= 0.27.0) - decidim-proposals (= 0.27.0) - decidim-surveys (0.27.0) - decidim-core (= 0.27.0) - decidim-forms (= 0.27.0) - decidim-templates (= 0.27.0) - decidim-system (0.27.0) + decidim-sortitions (0.28.0) + decidim-admin (= 0.28.0) + decidim-comments (= 0.28.0) + decidim-core (= 0.28.0) + decidim-proposals (= 0.28.0) + decidim-surveys (0.28.0) + decidim-core (= 0.28.0) + decidim-forms (= 0.28.0) + decidim-templates (= 0.28.0) + decidim-system (0.28.0) active_link_to (~> 1.0) - decidim-core (= 0.27.0) + decidim-core (= 0.28.0) devise (~> 4.7) devise-i18n (~> 1.2) - devise_invitable (~> 2.0) - decidim-templates (0.27.0) - decidim-core (= 0.27.0) - decidim-forms (= 0.27.0) - decidim-verifications (0.27.0) - decidim-core (= 0.27.0) - declarative-builder (0.1.0) - declarative-option (< 0.2.0) + devise_invitable (~> 2.0, >= 2.0.9) + decidim-templates (0.28.0) + decidim-core (= 0.28.0) + decidim-forms (= 0.28.0) + decidim-verifications (0.28.0) + decidim-core (= 0.28.0) + declarative-builder (0.2.0) + trailblazer-option (~> 0.1.0) declarative-option (0.1.0) - descendants_tracker (0.0.4) - thread_safe (~> 0.3, >= 0.3.1) - devise (4.9.2) + devise (4.9.4) bcrypt (~> 3.0) orm_adapter (~> 0.1) railties (>= 4.1.0) @@ -339,53 +324,62 @@ GEM warden (~> 1.2.3) devise-i18n (1.11.0) devise (>= 4.9.0) - devise_invitable (2.0.8) + devise_invitable (2.0.9) actionmailer (>= 5.0) devise (>= 4.6) - diff-lcs (1.5.0) - diffy (3.4.2) - doc2text (0.4.6) - nokogiri (>= 1.13.2, < 1.15.0) + diff-lcs (1.5.1) + diffy (3.4.3) + doc2text (0.4.7) + nokogiri (>= 1.13.2, < 1.17.0) rubyzip (~> 2.3.0) - docile (1.4.0) - doorkeeper (5.6.6) + docile (1.4.1) + doorkeeper (5.8.1) railties (>= 5) doorkeeper-i18n (4.0.1) - dumb_delegator (1.0.0) - erb_lint (0.0.37) + erb_lint (0.4.0) activesupport - better_html (~> 1.0.7) - html_tokenizer + better_html (>= 2.0.1) parser (>= 2.7.1.4) rainbow rubocop smart_properties erbse (0.1.4) temple - erubi (1.12.0) - escape_utils (1.3.0) - excon (0.100.0) - execjs (2.8.1) + erubi (1.13.1) + escape_utils (1.2.2) + excon (1.2.3) + execjs (2.10.0) extended-markdown-filter (0.7.0) html-pipeline (~> 2.9) - factory_bot (4.11.1) - activesupport (>= 3.0.0) - factory_bot_rails (4.11.1) - factory_bot (~> 4.11.1) - railties (>= 3.0.0) - faker (2.23.0) + factory_bot (6.5.0) + activesupport (>= 5.0.0) + factory_bot_rails (6.4.4) + factory_bot (~> 6.5) + railties (>= 5.0.0) + faker (3.5.1) i18n (>= 1.8.11, < 2) - faraday (2.7.7) - faraday-net_http (>= 2.0, < 3.1) - ruby2_keywords (>= 0.0.4) - faraday-net_http (3.0.2) - ffi (1.15.5) + faraday (2.12.2) + faraday-net_http (>= 2.0, < 3.5) + json + logger + faraday-net_http (3.4.0) + net-http (>= 0.5.0) + ffi (1.17.1-aarch64-linux-gnu) + ffi (1.17.1-aarch64-linux-musl) + ffi (1.17.1-arm-linux-gnu) + ffi (1.17.1-arm-linux-musl) + ffi (1.17.1-arm64-darwin) + ffi (1.17.1-x86-linux-gnu) + ffi (1.17.1-x86-linux-musl) + ffi (1.17.1-x86_64-darwin) + ffi (1.17.1-x86_64-linux-gnu) + ffi (1.17.1-x86_64-linux-musl) file_validators (3.0.0) activemodel (>= 3.2) mime-types (>= 1.0) - fog-core (2.3.0) + fog-core (2.6.0) builder - excon (~> 0.71) + excon (~> 1.0) formatador (>= 0.2, < 2.0) mime-types fog-local (0.8.0) @@ -397,50 +391,54 @@ GEM activesupport (>= 4.1, < 7.1) railties (>= 4.1, < 7.1) gemoji (3.0.1) - geocoder (1.8.1) - globalid (1.1.0) - activesupport (>= 5.0) - graphql (1.12.24) - graphql-docs (2.1.0) + geocoder (1.8.5) + base64 (>= 0.1.0) + csv (>= 3.0.0) + globalid (1.2.1) + activesupport (>= 6.1) + graphql (2.0.31) + base64 + graphql-docs (3.0.1) commonmarker (~> 0.16) - escape_utils (~> 1.2) + escape_utils (~> 1.2.2) extended-markdown-filter (~> 0.4) gemoji (~> 3.0) - graphql (~> 1.12) + graphql (~> 2.0) html-pipeline (~> 2.9) sass (~> 3.4) - hashdiff (1.0.1) + hashdiff (1.1.2) hashie (5.0.0) - highline (2.1.0) - hkdf (0.3.0) + highline (3.1.2) + reline html-pipeline (2.14.3) activesupport (>= 2) nokogiri (>= 1.4) - html_tokenizer (0.0.7) htmlentities (4.3.4) - i18n (1.14.1) + i18n (1.14.6) concurrent-ruby (~> 1.0) - i18n-tasks (0.9.37) + i18n-tasks (1.0.14) activesupport (>= 4.0.2) ast (>= 2.1.0) erubi highline (>= 2.0.0) i18n - parser (>= 2.2.3.0) + parser (>= 3.2.2.1) rails-i18n rainbow (>= 2.2.2, < 4.0) terminal-table (>= 1.5.1) - icalendar (2.8.0) + icalendar (2.10.3) ice_cube (~> 0.16) - ice_cube (0.16.4) - ice_nine (0.11.2) - image_processing (1.12.2) + ostruct + ice_cube (0.17.0) + image_processing (1.13.0) mini_magick (>= 4.9.5, < 5) ruby-vips (>= 2.0.17, < 3) invisible_captcha (0.13.0) rails (>= 3.2.0) - json (2.6.3) - jwt (2.7.1) + io-console (0.8.0) + json (2.9.1) + jwt (2.10.1) + base64 kaminari (1.2.2) activesupport (>= 4.1.0) kaminari-actionview (= 1.2.2) @@ -453,65 +451,63 @@ GEM activerecord kaminari-core (= 1.2.2) kaminari-core (1.2.2) - kramdown (2.4.0) - rexml - kramdown-parser-gfm (1.1.0) - kramdown (~> 2.0) - launchy (2.5.2) + launchy (3.0.1) addressable (~> 2.8) - letter_opener (1.8.1) - launchy (>= 2.2, < 3) + childprocess (~> 5.0) + letter_opener (1.10.0) + launchy (>= 2.2, < 4) letter_opener_web (1.4.1) actionmailer (>= 3.2) letter_opener (~> 1.0) railties (>= 3.2) - listen (3.8.0) + listen (3.9.0) rb-fsevent (~> 0.10, >= 0.10.3) rb-inotify (~> 0.9, >= 0.9.10) - loofah (2.3.1) + logger (1.6.4) + loofah (2.24.0) crass (~> 1.0.2) - nokogiri (>= 1.5.9) + nokogiri (>= 1.12.0) mail (2.8.1) mini_mime (>= 0.1.1) net-imap net-pop net-smtp - marcel (1.0.2) + marcel (1.0.4) matrix (0.4.2) - mdl (0.12.0) - kramdown (~> 2.3) - kramdown-parser-gfm (~> 1.1) - mixlib-cli (~> 2.1, >= 2.1.1) - mixlib-config (>= 2.2.1, < 4) - mixlib-shellout - method_source (1.0.0) - mime-types (3.4.1) + method_source (1.1.0) + mime-types (3.6.0) + logger mime-types-data (~> 3.2015) - mime-types-data (3.2023.0218.1) - mini_magick (4.12.0) - mini_mime (1.1.2) - mini_portile2 (2.8.2) - minitest (5.18.1) - mixlib-cli (2.1.8) - mixlib-config (3.0.27) - tomlrb - mixlib-shellout (3.2.7) - chef-utils - msgpack (1.7.1) + mime-types-data (3.2025.0107) + mini_magick (4.13.2) + mini_mime (1.1.5) + minitest (5.25.4) + msgpack (1.7.5) multi_xml (0.6.0) mustache (1.1.1) - net-imap (0.3.6) + net-http (0.6.0) + uri + net-imap (0.5.5) date net-protocol net-pop (0.1.2) net-protocol - net-protocol (0.2.1) + net-protocol (0.2.2) timeout - net-smtp (0.3.3) + net-smtp (0.3.4) net-protocol - nio4r (2.5.9) - nokogiri (1.14.5) - mini_portile2 (~> 2.8.0) + nio4r (2.7.4) + nokogiri (1.16.8-aarch64-linux) + racc (~> 1.4) + nokogiri (1.16.8-arm-linux) + racc (~> 1.4) + nokogiri (1.16.8-arm64-darwin) + racc (~> 1.4) + nokogiri (1.16.8-x86-linux) + racc (~> 1.4) + nokogiri (1.16.8-x86_64-darwin) + racc (~> 1.4) + nokogiri (1.16.8-x86_64-linux) racc (~> 1.4) oauth (1.1.0) oauth-tty (~> 1.0, >= 1.0.1) @@ -526,173 +522,194 @@ GEM rack (>= 1.2, < 4) snaky_hash (~> 2.0) version_gem (~> 1.1) - omniauth (2.1.1) + omniauth (2.1.2) hashie (>= 3.4.6) rack (>= 2.2.3) rack-protection omniauth-facebook (5.0.0) omniauth-oauth2 (~> 1.2) - omniauth-google-oauth2 (1.1.1) - jwt (>= 2.0) - oauth2 (~> 2.0.6) + omniauth-google-oauth2 (1.2.0) + jwt (>= 2.9) + oauth2 (~> 2.0) omniauth (~> 2.0) - omniauth-oauth2 (~> 1.8.0) - omniauth-oauth (1.2.0) + omniauth-oauth2 (~> 1.8) + omniauth-oauth (1.2.1) oauth omniauth (>= 1.0, < 3) + rack (>= 1.6.2, < 4) omniauth-oauth2 (1.8.0) oauth2 (>= 1.4, < 3) omniauth (~> 2.0) - omniauth-rails_csrf_protection (1.0.1) + omniauth-rails_csrf_protection (1.0.2) actionpack (>= 4.2) omniauth (~> 2.0) omniauth-twitter (1.4.0) omniauth-oauth (~> 1.1) rack + openssl (3.3.0) orm_adapter (0.5.0) + ostruct (0.6.1) paper_trail (12.3.0) activerecord (>= 5.2) request_store (~> 1.1) - parallel (1.23.0) - parallel_tests (3.13.0) + parallel (1.26.3) + parallel_tests (4.8.0) parallel - parser (3.2.2.3) + parser (3.3.6.0) ast (~> 2.4.1) racc - pg (1.1.4) - pg_search (2.3.6) - activerecord (>= 5.2) - activesupport (>= 5.2) - premailer (1.21.0) + pg (1.4.6) + pg_search (2.3.7) + activerecord (>= 6.1) + activesupport (>= 6.1) + premailer (1.27.0) addressable - css_parser (>= 1.12.0) + css_parser (>= 1.19.0) htmlentities (>= 4.0.0) premailer-rails (1.12.0) actionmailer (>= 3) net-smtp premailer (~> 1.7, >= 1.7.9) - public_suffix (5.0.1) - puma (5.6.6) + psych (4.0.6) + stringio + public_suffix (6.0.1) + puma (6.5.0) nio4r (~> 2.0) - racc (1.7.1) - rack (2.2.7) - rack-attack (6.6.1) - rack (>= 1.0, < 3) + racc (1.8.1) + rack (2.2.10) + rack-attack (6.7.0) + rack (>= 1.0, < 4) rack-cors (1.1.1) rack (>= 2.0.0) - rack-protection (3.0.6) + rack-protection (3.2.0) + base64 (>= 0.1.0) + rack (~> 2.2, >= 2.2.4) + rack-proxy (0.7.7) rack - rack-proxy (0.7.6) - rack - rack-test (2.1.0) + rack-test (2.2.0) rack (>= 1.3) - rails (6.1.7.3) - actioncable (= 6.1.7.3) - actionmailbox (= 6.1.7.3) - actionmailer (= 6.1.7.3) - actionpack (= 6.1.7.3) - actiontext (= 6.1.7.3) - actionview (= 6.1.7.3) - activejob (= 6.1.7.3) - activemodel (= 6.1.7.3) - activerecord (= 6.1.7.3) - activestorage (= 6.1.7.3) - activesupport (= 6.1.7.3) + rails (6.1.7.10) + actioncable (= 6.1.7.10) + actionmailbox (= 6.1.7.10) + actionmailer (= 6.1.7.10) + actionpack (= 6.1.7.10) + actiontext (= 6.1.7.10) + actionview (= 6.1.7.10) + activejob (= 6.1.7.10) + activemodel (= 6.1.7.10) + activerecord (= 6.1.7.10) + activestorage (= 6.1.7.10) + activesupport (= 6.1.7.10) bundler (>= 1.15.0) - railties (= 6.1.7.3) + railties (= 6.1.7.10) sprockets-rails (>= 2.0.0) rails-controller-testing (1.0.5) actionpack (>= 5.0.1.rc1) actionview (>= 5.0.1.rc1) activesupport (>= 5.0.1.rc1) - rails-dom-testing (2.0.3) - activesupport (>= 4.2.0) + rails-dom-testing (2.2.0) + activesupport (>= 5.0.0) + minitest nokogiri (>= 1.6) - rails-html-sanitizer (1.4.3) - loofah (~> 2.3) + rails-html-sanitizer (1.6.2) + loofah (~> 2.21) + nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0) rails-i18n (6.0.0) i18n (>= 0.7, < 2) railties (>= 6.0.0, < 7) - railties (6.1.7.3) - actionpack (= 6.1.7.3) - activesupport (= 6.1.7.3) + railties (6.1.7.10) + actionpack (= 6.1.7.10) + activesupport (= 6.1.7.10) method_source rake (>= 12.2) thor (~> 1.0) rainbow (3.1.1) - rake (13.0.6) - ransack (2.4.2) - activerecord (>= 5.2.4) - activesupport (>= 5.2.4) + rake (13.2.1) + ransack (3.2.1) + activerecord (>= 6.1.5) + activesupport (>= 6.1.5) i18n rb-fsevent (0.11.2) - rb-inotify (0.10.1) + rb-inotify (0.11.1) ffi (~> 1.0) redcarpet (3.6.0) redis (4.8.1) - regexp_parser (2.8.1) + regexp_parser (2.10.0) + reline (0.6.0) + io-console (~> 0.5) request_store (1.5.1) rack (>= 1.4) - responders (3.1.0) + responders (3.1.1) actionpack (>= 5.2) railties (>= 5.2) - rexml (3.2.5) - rspec (3.12.0) - rspec-core (~> 3.12.0) - rspec-expectations (~> 3.12.0) - rspec-mocks (~> 3.12.0) - rspec-cells (0.3.8) + rexml (3.4.0) + rspec (3.13.0) + rspec-core (~> 3.13.0) + rspec-expectations (~> 3.13.0) + rspec-mocks (~> 3.13.0) + rspec-cells (0.3.10) cells (>= 4.0.0, < 6.0.0) - rspec-rails (>= 3.0.0, < 6.1.0) - rspec-core (3.12.2) - rspec-support (~> 3.12.0) - rspec-expectations (3.12.3) + rspec-rails (>= 3.0.0) + rspec-core (3.13.2) + rspec-support (~> 3.13.0) + rspec-expectations (3.13.3) diff-lcs (>= 1.2.0, < 2.0) - rspec-support (~> 3.12.0) - rspec-html-matchers (0.9.4) + rspec-support (~> 3.13.0) + rspec-html-matchers (0.10.0) nokogiri (~> 1) - rspec (>= 3.0.0.a, < 4) - rspec-mocks (3.12.5) + rspec (>= 3.0.0.a) + rspec-mocks (3.13.2) diff-lcs (>= 1.2.0, < 2.0) - rspec-support (~> 3.12.0) - rspec-rails (4.1.2) - actionpack (>= 4.2) - activesupport (>= 4.2) - railties (>= 4.2) - rspec-core (~> 3.10) - rspec-expectations (~> 3.10) - rspec-mocks (~> 3.10) - rspec-support (~> 3.10) + rspec-support (~> 3.13.0) + rspec-rails (6.1.5) + actionpack (>= 6.1) + activesupport (>= 6.1) + railties (>= 6.1) + rspec-core (~> 3.13) + rspec-expectations (~> 3.13) + rspec-mocks (~> 3.13) + rspec-support (~> 3.13) rspec-retry (0.6.2) rspec-core (> 3.3) - rspec-support (3.12.0) - rspec_junit_formatter (0.3.0) + rspec-support (3.13.2) + rspec_junit_formatter (0.6.0) rspec-core (>= 2, < 4, != 2.12.0) - rubocop (1.28.2) + rubocop (1.50.2) + json (~> 2.3) parallel (~> 1.10) - parser (>= 3.1.0.0) + parser (>= 3.2.0.0) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) - rexml - rubocop-ast (>= 1.17.0, < 2.0) + rexml (>= 3.2.5, < 4.0) + rubocop-ast (>= 1.28.0, < 2.0) ruby-progressbar (~> 1.7) - unicode-display_width (>= 1.4.0, < 3.0) - rubocop-ast (1.29.0) - parser (>= 3.2.1.0) - rubocop-faker (1.1.0) + unicode-display_width (>= 2.4.0, < 3.0) + rubocop-ast (1.37.0) + parser (>= 3.3.1.0) + rubocop-capybara (2.21.0) + rubocop (~> 1.41) + rubocop-factory_bot (2.26.0) + rubocop (~> 1.41) + rubocop-faker (1.2.0) faker (>= 2.12.0) - rubocop (>= 0.82.0) - rubocop-rails (2.15.2) + rubocop (>= 1.13.0) + rubocop-rails (2.25.1) activesupport (>= 4.2.0) rack (>= 1.1) - rubocop (>= 1.7.0, < 2.0) - rubocop-rspec (2.11.1) - rubocop (~> 1.19) + rubocop (>= 1.33.0, < 2.0) + rubocop-ast (>= 1.31.1, < 2.0) + rubocop-rspec (2.31.0) + rubocop (~> 1.40) + rubocop-capybara (~> 2.17) + rubocop-factory_bot (~> 2.22) + rubocop-rspec_rails (~> 2.28) + rubocop-rspec_rails (2.29.0) + rubocop (~> 1.40) ruby-progressbar (1.13.0) - ruby-vips (2.1.4) + ruby-vips (2.2.2) ffi (~> 1.12) - ruby2_keywords (0.0.5) - rubyXL (3.4.25) + logger + rubyXL (3.4.33) nokogiri (>= 1.10.8) rubyzip (>= 1.3.0) rubyzip (2.3.2) @@ -701,61 +718,64 @@ GEM sass-listen (4.0.0) rb-fsevent (~> 0.9, >= 0.9.4) rb-inotify (~> 0.9, >= 0.9.7) - selenium-webdriver (4.1.0) - childprocess (>= 0.5, < 5.0) + selenium-webdriver (4.27.0) + base64 (~> 0.2) + logger (~> 1.4) rexml (~> 3.2, >= 3.2.5) - rubyzip (>= 1.2.2) - semantic_range (3.0.0) + rubyzip (>= 1.2.2, < 3.0) + websocket (~> 1.0) + semantic_range (3.1.0) seven_zip_ruby (1.3.0) - simplecov (0.21.2) + shakapacker (7.1.0) + activesupport (>= 5.2) + rack-proxy (>= 0.6.1) + railties (>= 5.2) + semantic_range (>= 2.3.0) + simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) simplecov_json_formatter (~> 0.1) simplecov-cobertura (2.1.0) rexml simplecov (~> 0.19) - simplecov-html (0.12.3) + simplecov-html (0.13.1) simplecov_json_formatter (0.1.4) smart_properties (1.17.0) snaky_hash (2.0.1) hashie version_gem (~> 1.1, >= 1.1.1) - social-share-button (1.2.4) - coffee-rails spring (2.1.1) spring-watcher-listen (2.0.1) listen (>= 2.7, < 4.0) spring (>= 1.2, < 3.0) - sprockets (4.2.0) + sprockets (4.2.1) concurrent-ruby (~> 1.0) rack (>= 2.2.4, < 4) - sprockets-rails (3.4.2) - actionpack (>= 5.2) - activesupport (>= 5.2) + sprockets-rails (3.5.2) + actionpack (>= 6.1) + activesupport (>= 6.1) sprockets (>= 3.0.0) - ssrf_filter (1.1.1) - temple (0.10.2) + ssrf_filter (1.2.0) + stringio (3.1.2) + temple (0.10.3) terminal-table (3.0.2) unicode-display_width (>= 1.1.1, < 3) - thor (1.2.2) - thread_safe (0.3.6) - tilt (2.2.0) - timeout (0.4.0) - tomlrb (2.0.3) + thor (1.3.2) + tilt (2.5.0) + timeout (0.4.3) + trailblazer-option (0.1.2) tzinfo (2.0.6) concurrent-ruby (~> 1.0) uber (0.1.0) - uglifier (4.2.0) + uglifier (4.2.1) execjs (>= 0.3.0, < 3) - unicode-display_width (2.4.2) - valid_email2 (2.3.1) + unicode-display_width (2.6.0) + uniform_notifier (1.16.0) + uri (1.0.2) + valid_email2 (4.0.6) activemodel (>= 3.2) mail (~> 2.5) - version_gem (1.1.3) - virtus (2.0.0) - axiom-types (~> 0.1) - coercible (~> 1.0) - descendants_tracker (~> 0.0, >= 0.0.3) + version_gem (1.1.4) w3c_rspec_validators (0.3.0) rails rspec @@ -771,41 +791,52 @@ GEM activemodel (>= 5.0) bindex (>= 0.4.0) railties (>= 5.0) - webmock (3.18.1) + web-push (3.0.1) + jwt (~> 2.0) + openssl (~> 3.0) + webmock (3.24.0) addressable (>= 2.8.0) crack (>= 0.3.2) hashdiff (>= 0.4.0, < 2.0.0) - webpacker (6.0.0.rc.5) - activesupport (>= 5.2) - rack-proxy (>= 0.6.1) - railties (>= 5.2) - semantic_range (>= 2.3.0) - webpush (1.1.0) - hkdf (~> 0.2) - jwt (~> 2.0) - websocket-driver (0.7.5) + websocket (1.2.11) + websocket-driver (0.7.7) + base64 websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) - wicked_pdf (2.6.3) + wicked_pdf (2.8.2) activesupport + ostruct wisper (2.0.1) wisper-rspec (1.1.0) - wkhtmltopdf-binary (0.12.6.6) + wkhtmltopdf-binary (0.12.6.8) xpath (3.2.0) nokogiri (~> 1.8) - zeitwerk (2.6.8) + zeitwerk (2.6.18) PLATFORMS - ruby + aarch64-linux + aarch64-linux-gnu + aarch64-linux-musl + arm-linux + arm-linux-gnu + arm-linux-musl + arm64-darwin + x86-linux + x86-linux-gnu + x86-linux-musl + x86_64-darwin + x86_64-linux + x86_64-linux-gnu + x86_64-linux-musl DEPENDENCIES bootsnap (~> 1.4) byebug (~> 11.0) codecov - decidim (= 0.27) - decidim-dev (= 0.27) + decidim (= 0.28) + decidim-dev (= 0.28) decidim-notify! - faker (~> 2.14) + faker letter_opener_web (~> 1.3) listen (~> 3.1) puma (>= 5.0.0) @@ -816,7 +847,7 @@ DEPENDENCIES web-console (~> 3.5) RUBY VERSION - ruby 3.0.2p107 + ruby 3.1.1p18 BUNDLED WITH - 2.1.4 + 2.5.23 diff --git a/app/cells/decidim/notify/chapter/show.erb b/app/cells/decidim/notify/chapter/show.erb index a2c701c..e872ef6 100644 --- a/app/cells/decidim/notify/chapter/show.erb +++ b/app/cells/decidim/notify/chapter/show.erb @@ -3,7 +3,7 @@

"> <%= title %> <% if note_taker? %> - + <% end %> diff --git a/lib/decidim/notify/version.rb b/lib/decidim/notify/version.rb index 7bad532..161d511 100644 --- a/lib/decidim/notify/version.rb +++ b/lib/decidim/notify/version.rb @@ -3,7 +3,7 @@ module Decidim # This holds the decidim-notify version. module Notify - VERSION = "0.6" - COMPAT_DECIDIM_VERSION = [">= 0.27.0", "< 0.28"].freeze + VERSION = "0.7" + COMPAT_DECIDIM_VERSION = [">= 0.28.0", "< 0.29"].freeze end end diff --git a/package.json b/package.json index b45acd0..051747a 100644 --- a/package.json +++ b/package.json @@ -192,5 +192,6 @@ "dependencies": { "@rails/actioncable": "6.1.7", "select2": "^4.1.0-rc.0" - } + }, + "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" } diff --git a/test.txt b/test.txt new file mode 100644 index 0000000..212cb38 --- /dev/null +++ b/test.txt @@ -0,0 +1,239 @@ +/Users/harrisonhassig/.rbenv/versions/3.1.1/bin/ruby -I/Users/harrisonhassig/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.13.2/lib:/Users/harrisonhassig/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-support-3.13.2/lib /Users/harrisonhassig/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.13.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb + +Randomized with seed 4850 + +Decidim::Notify::ChapterForm + when everything is OK + is expected to be valid + +Decidim::Notify::ConversationsController + DELETE #destroy + deletes the note + POST #create + creates a new note + GET #index + renders the index listing + PATCH #update + updates the note + +I18n sanity + is normalized + does not have missing keys + does not have unused keys + +Decidim::Notify::ParticipantCell + when rendering a participant + renders the user + renders the number + +Decidim::Notify::Admin::ChaptersController + POST #create + when there is permission + returns ok + creates the new chapter + DELETE #destroy + when there is permission + returns ok + updates the new chapter + GET #new + renders the empty form + PATCH #update + when there is permission + updates the new chapter + returns ok + GET #index + renders the index listing + +Decidim::Notify::Note + is associated with a component + is expected to be valid + when component is not notify + is expected to be invalid + when the note has a chapter + is has an chapter + when obtaining all elements for the component + returns current element + when the note has an author + is has an author + when the note is created + is does not have an author + is associated with a creator + is does not have a chapter + +Decidim::Notify::Admin::NotifyConfigForm + when everything is OK + is expected to be valid + +Decidim::Notify::Author + is expected to be valid + is associated with a component + when the author is created + is has an user + when obtaining all elements for the component + returns current element + when the author has not an user + is does not have an user + when the author has notes + returns all his notes + when component is not notify + is expected to be invalid + +Decidim::Notify::ChapterCell + when rendering a chapter + is not active + renders the chapter + do not render the edit button + when user is note_taker + renders the edit button (FAILED - 1) + when is active + is active + +Decidim::Notify::Admin::ChapterForm + when everything is OK + is expected to be valid + when there's no title + is expected not to be valid + +Decidim::Notify::NoteCell + when rendering a note + renders the body + do not render the edit button + renders the author + when user is note_taker + renders the edit button (FAILED - 2) + +Decidim::Notify::Chapter + is expected to be valid + is associated with a component + when component is not notify + is expected to be invalid + when obtaining all elements for the component + returns current element + +Decidim::Notify::NoteForm + when there's no body + is expected not to be valid + when everything is OK + is expected to be valid + +Decidim::Notify::Admin::ConversationsController + GET #index + renders the index listing + POST #create + when there is permission + creates users and note_takers for the component + returns ok + +Decidim::Notify::ChaptersController + DELETE #destroy + deletes the chapter + PATCH #update + creates a new chapter + +Failures: + + 1) Decidim::Notify::ChapterCell when user is note_taker renders the edit button + Failure/Error: + + Shakapacker::Manifest::MissingEntryError: + Shakapacker can't find media/images/remixicon.symbol.svg in /Users/harrisonhassig/code/HHassig/platoniq/decidim-module-notify/spec/decidim_dummy_app/public/packs-test/manifest.json. Possible causes: + 1. You forgot to install node packages (try `yarn install`) or are running an incompatible version of Node + 2. Your app has code with a non-standard extension (like a `.jsx` file) but the extension is not in the `extensions` config in `config/shakapacker.yml` + 3. You have set compile: false (see `config/shakapacker.yml`) for this environment + (unless you are using the `bin/shakapacker -w` or the `bin/shakapacker-dev-server`, in which case maybe you aren't running the dev server in the background?) + 4. webpack has not yet FINISHED running to reflect updates. + 5. You have misconfigured Shakapacker's `config/shakapacker.yml` file. + 6. Your webpack configuration is not creating a manifest. + + Your manifest contains: + {} + # ./app/cells/decidim/notify/chapter/show.erb:6:in `__tilt_58080' + # ./app/cells/decidim/notify/chapter_cell.rb:13:in `show' + # ./spec/cells/chapter_cell_spec.rb:7:in `block (2 levels) in ' + # ./spec/cells/chapter_cell_spec.rb:37:in `block (3 levels) in ' + + 2) Decidim::Notify::NoteCell when user is note_taker renders the edit button + Failure/Error: <%= icon "trash" %> + + RuntimeError: + Icon trash not found. Register it with + + Decidim.icons.register(name: "trash", icon: "trash", category: "system", description: "", engine: :core) + + # ./app/cells/decidim/notify/note/show.erb:13:in `block in __tilt_58080' + # ./app/cells/decidim/notify/note/show.erb:12:in `__tilt_58080' + # ./spec/cells/note_cell_spec.rb:7:in `block (2 levels) in ' + # ./spec/cells/note_cell_spec.rb:37:in `block (3 levels) in ' + +Top 10 slowest examples (15.99 seconds, 38.5% of total time): + Decidim::Notify::ConversationsController DELETE #destroy deletes the note + 3.33 seconds ./spec/controllers/conversations_controller_spec.rb:60 + Decidim::Notify::Author when the author has notes returns all his notes + 1.96 seconds ./spec/models/author_spec.rb:33 + Decidim::Notify::NoteCell when user is note_taker renders the edit button + 1.59 seconds ./spec/cells/note_cell_spec.rb:36 + Decidim::Notify::NoteCell when rendering a note renders the author + 1.59 seconds ./spec/cells/note_cell_spec.rb:16 + Decidim::Notify::NoteCell when rendering a note renders the body + 1.58 seconds ./spec/cells/note_cell_spec.rb:21 + Decidim::Notify::NoteCell when rendering a note do not render the edit button + 1.57 seconds ./spec/cells/note_cell_spec.rb:26 + Decidim::Notify::Note when component is not notify is expected to be invalid + 1.2 seconds ./lib/decidim/notify/test/shared_examples/component_examples.rb:15 + Decidim::Notify::Author when component is not notify is expected to be invalid + 1.17 seconds ./lib/decidim/notify/test/shared_examples/component_examples.rb:15 + Decidim::Notify::Note when the note has an author is has an author + 1.16 seconds ./spec/models/note_spec.rb:34 + Decidim::Notify::Chapter when component is not notify is expected to be invalid + 0.84231 seconds ./lib/decidim/notify/test/shared_examples/component_examples.rb:15 + +Top 10 slowest example groups: + Decidim::Notify::NoteCell + 1.58 seconds average (6.33 seconds / 4 examples) ./spec/cells/note_cell_spec.rb:6 + Decidim::Notify::ConversationsController + 1.28 seconds average (5.11 seconds / 4 examples) ./spec/controllers/conversations_controller_spec.rb:6 + Decidim::Notify::Author + 0.95481 seconds average (6.68 seconds / 7 examples) ./spec/models/author_spec.rb:7 + Decidim::Notify::Note + 0.872 seconds average (7.85 seconds / 9 examples) ./spec/models/note_spec.rb:7 + Decidim::Notify::ChapterCell + 0.7979 seconds average (3.99 seconds / 5 examples) ./spec/cells/chapter_cell_spec.rb:6 + Decidim::Notify::ParticipantCell + 0.78534 seconds average (1.57 seconds / 2 examples) ./spec/cells/participant_cell_spec.rb:6 + Decidim::Notify::Admin::NotifyConfigForm + 0.76576 seconds average (0.76576 seconds / 1 example) ./spec/forms/admin/notify_config_form_spec.rb:6 + Decidim::Notify::Admin::ConversationsController + 0.54164 seconds average (1.62 seconds / 3 examples) ./spec/controllers/admin/conversations_controller_spec.rb:6 + Decidim::Notify::Chapter + 0.51141 seconds average (2.05 seconds / 4 examples) ./spec/models/chapter_spec.rb:7 + Decidim::Notify::ChaptersController + 0.43065 seconds average (0.8613 seconds / 2 examples) ./spec/controllers/chapters_controller_spec.rb:6 + +Finished in 41.58 seconds (files took 4.15 seconds to load) +57 examples, 2 failures + +Failed examples: + +rspec ./spec/cells/chapter_cell_spec.rb:36 # Decidim::Notify::ChapterCell when user is note_taker renders the edit button +rspec ./spec/cells/note_cell_spec.rb:36 # Decidim::Notify::NoteCell when user is note_taker renders the edit button + +Randomized with seed 4850 + + + _____ _ + / ____| | | +| | ___ __| | ___ ___ _____ __ +| | / _ \ / _\`|/ _ \/ __/ _ \ \ / / +| |___| (_) | (_| | __/ (_| (_) \ V / + \_____\___/ \__,_|\___|\___\___/ \_/ + Ruby-0.2.12 +x> No CI provider detected. +==> Appending file network +==> Gzipping contents +==> Uploading reports + url: https://codecov.io + query: token=secret&flags&package=ruby-0.2.12&branch=deps%2Fdecidim-0.28&commit=120d15ec21ff6c53d2748461e3ac384478bac419 +->  Pinging Codecov +https://codecov.io/upload/v4?token=secret&flags&package=ruby-0.2.12&branch=deps%2Fdecidim-0.28&commit=120d15ec21ff6c53d2748461e3ac384478bac419 +{"message":"Token required - not valid tokenless upload"} + From 9cf2e70b9ba5aca33c5d4e87f72157e117421377 Mon Sep 17 00:00:00 2001 From: Harrison Hassig Date: Fri, 10 Jan 2025 09:22:40 +0100 Subject: [PATCH 02/11] Changed icons, tests still failing --- app/cells/decidim/notify/chapter/show.erb | 2 +- app/cells/decidim/notify/note/show.erb | 2 +- .../stylesheets/decidim/notify/notify.scss | 4 +- test.txt | 239 ------------------ 4 files changed, 4 insertions(+), 243 deletions(-) delete mode 100644 test.txt diff --git a/app/cells/decidim/notify/chapter/show.erb b/app/cells/decidim/notify/chapter/show.erb index e872ef6..ceed445 100644 --- a/app/cells/decidim/notify/chapter/show.erb +++ b/app/cells/decidim/notify/chapter/show.erb @@ -21,7 +21,7 @@ <%= form.submit t("update", scope: "decidim.notify.chapter"), class: "button small" %> <% end %> <%= button_to update_path, method: :delete, remote: true, class: "delete", title: t("delete", scope: "decidim.notify.chapter"), data: { confirm: t("destroy.sure", scope: "decidim.notify.chapter") } do %> - <%= icon "trash" %> + <%= icon "delete-bin-line" %> <% end %> <% end %> diff --git a/app/cells/decidim/notify/note/show.erb b/app/cells/decidim/notify/note/show.erb index 59e99ff..d75b90d 100644 --- a/app/cells/decidim/notify/note/show.erb +++ b/app/cells/decidim/notify/note/show.erb @@ -10,7 +10,7 @@ <% if note_taker? %>
<%= link_to edit_path, method: :delete, remote: true, class: "delete", data: { confirm: t("decidim.notify.conversations.destroy.sure") } do %> - <%= icon "trash" %> + <%= icon "delete-bin-line" %> <% end %> <%= link_to edit_path, class: "edit" do %> <%= icon "pencil-line" %> diff --git a/app/packs/stylesheets/decidim/notify/notify.scss b/app/packs/stylesheets/decidim/notify/notify.scss index dab9b2b..68def77 100644 --- a/app/packs/stylesheets/decidim/notify/notify.scss +++ b/app/packs/stylesheets/decidim/notify/notify.scss @@ -1,5 +1,5 @@ // From Decidicim core -@import 'stylesheets/decidim/variables'; +@import 'stylesheets/decidim/legacy/variables'; @import 'stylesheets/decidim/utils/settings'; // From npm package @import "select2/dist/css/select2.css"; @@ -227,4 +227,4 @@ } } } -} \ No newline at end of file +} diff --git a/test.txt b/test.txt deleted file mode 100644 index 212cb38..0000000 --- a/test.txt +++ /dev/null @@ -1,239 +0,0 @@ -/Users/harrisonhassig/.rbenv/versions/3.1.1/bin/ruby -I/Users/harrisonhassig/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.13.2/lib:/Users/harrisonhassig/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-support-3.13.2/lib /Users/harrisonhassig/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rspec-core-3.13.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb - -Randomized with seed 4850 - -Decidim::Notify::ChapterForm - when everything is OK - is expected to be valid - -Decidim::Notify::ConversationsController - DELETE #destroy - deletes the note - POST #create - creates a new note - GET #index - renders the index listing - PATCH #update - updates the note - -I18n sanity - is normalized - does not have missing keys - does not have unused keys - -Decidim::Notify::ParticipantCell - when rendering a participant - renders the user - renders the number - -Decidim::Notify::Admin::ChaptersController - POST #create - when there is permission - returns ok - creates the new chapter - DELETE #destroy - when there is permission - returns ok - updates the new chapter - GET #new - renders the empty form - PATCH #update - when there is permission - updates the new chapter - returns ok - GET #index - renders the index listing - -Decidim::Notify::Note - is associated with a component - is expected to be valid - when component is not notify - is expected to be invalid - when the note has a chapter - is has an chapter - when obtaining all elements for the component - returns current element - when the note has an author - is has an author - when the note is created - is does not have an author - is associated with a creator - is does not have a chapter - -Decidim::Notify::Admin::NotifyConfigForm - when everything is OK - is expected to be valid - -Decidim::Notify::Author - is expected to be valid - is associated with a component - when the author is created - is has an user - when obtaining all elements for the component - returns current element - when the author has not an user - is does not have an user - when the author has notes - returns all his notes - when component is not notify - is expected to be invalid - -Decidim::Notify::ChapterCell - when rendering a chapter - is not active - renders the chapter - do not render the edit button - when user is note_taker - renders the edit button (FAILED - 1) - when is active - is active - -Decidim::Notify::Admin::ChapterForm - when everything is OK - is expected to be valid - when there's no title - is expected not to be valid - -Decidim::Notify::NoteCell - when rendering a note - renders the body - do not render the edit button - renders the author - when user is note_taker - renders the edit button (FAILED - 2) - -Decidim::Notify::Chapter - is expected to be valid - is associated with a component - when component is not notify - is expected to be invalid - when obtaining all elements for the component - returns current element - -Decidim::Notify::NoteForm - when there's no body - is expected not to be valid - when everything is OK - is expected to be valid - -Decidim::Notify::Admin::ConversationsController - GET #index - renders the index listing - POST #create - when there is permission - creates users and note_takers for the component - returns ok - -Decidim::Notify::ChaptersController - DELETE #destroy - deletes the chapter - PATCH #update - creates a new chapter - -Failures: - - 1) Decidim::Notify::ChapterCell when user is note_taker renders the edit button - Failure/Error: - - Shakapacker::Manifest::MissingEntryError: - Shakapacker can't find media/images/remixicon.symbol.svg in /Users/harrisonhassig/code/HHassig/platoniq/decidim-module-notify/spec/decidim_dummy_app/public/packs-test/manifest.json. Possible causes: - 1. You forgot to install node packages (try `yarn install`) or are running an incompatible version of Node - 2. Your app has code with a non-standard extension (like a `.jsx` file) but the extension is not in the `extensions` config in `config/shakapacker.yml` - 3. You have set compile: false (see `config/shakapacker.yml`) for this environment - (unless you are using the `bin/shakapacker -w` or the `bin/shakapacker-dev-server`, in which case maybe you aren't running the dev server in the background?) - 4. webpack has not yet FINISHED running to reflect updates. - 5. You have misconfigured Shakapacker's `config/shakapacker.yml` file. - 6. Your webpack configuration is not creating a manifest. - - Your manifest contains: - {} - # ./app/cells/decidim/notify/chapter/show.erb:6:in `__tilt_58080' - # ./app/cells/decidim/notify/chapter_cell.rb:13:in `show' - # ./spec/cells/chapter_cell_spec.rb:7:in `block (2 levels) in ' - # ./spec/cells/chapter_cell_spec.rb:37:in `block (3 levels) in ' - - 2) Decidim::Notify::NoteCell when user is note_taker renders the edit button - Failure/Error: <%= icon "trash" %> - - RuntimeError: - Icon trash not found. Register it with - - Decidim.icons.register(name: "trash", icon: "trash", category: "system", description: "", engine: :core) - - # ./app/cells/decidim/notify/note/show.erb:13:in `block in __tilt_58080' - # ./app/cells/decidim/notify/note/show.erb:12:in `__tilt_58080' - # ./spec/cells/note_cell_spec.rb:7:in `block (2 levels) in ' - # ./spec/cells/note_cell_spec.rb:37:in `block (3 levels) in ' - -Top 10 slowest examples (15.99 seconds, 38.5% of total time): - Decidim::Notify::ConversationsController DELETE #destroy deletes the note - 3.33 seconds ./spec/controllers/conversations_controller_spec.rb:60 - Decidim::Notify::Author when the author has notes returns all his notes - 1.96 seconds ./spec/models/author_spec.rb:33 - Decidim::Notify::NoteCell when user is note_taker renders the edit button - 1.59 seconds ./spec/cells/note_cell_spec.rb:36 - Decidim::Notify::NoteCell when rendering a note renders the author - 1.59 seconds ./spec/cells/note_cell_spec.rb:16 - Decidim::Notify::NoteCell when rendering a note renders the body - 1.58 seconds ./spec/cells/note_cell_spec.rb:21 - Decidim::Notify::NoteCell when rendering a note do not render the edit button - 1.57 seconds ./spec/cells/note_cell_spec.rb:26 - Decidim::Notify::Note when component is not notify is expected to be invalid - 1.2 seconds ./lib/decidim/notify/test/shared_examples/component_examples.rb:15 - Decidim::Notify::Author when component is not notify is expected to be invalid - 1.17 seconds ./lib/decidim/notify/test/shared_examples/component_examples.rb:15 - Decidim::Notify::Note when the note has an author is has an author - 1.16 seconds ./spec/models/note_spec.rb:34 - Decidim::Notify::Chapter when component is not notify is expected to be invalid - 0.84231 seconds ./lib/decidim/notify/test/shared_examples/component_examples.rb:15 - -Top 10 slowest example groups: - Decidim::Notify::NoteCell - 1.58 seconds average (6.33 seconds / 4 examples) ./spec/cells/note_cell_spec.rb:6 - Decidim::Notify::ConversationsController - 1.28 seconds average (5.11 seconds / 4 examples) ./spec/controllers/conversations_controller_spec.rb:6 - Decidim::Notify::Author - 0.95481 seconds average (6.68 seconds / 7 examples) ./spec/models/author_spec.rb:7 - Decidim::Notify::Note - 0.872 seconds average (7.85 seconds / 9 examples) ./spec/models/note_spec.rb:7 - Decidim::Notify::ChapterCell - 0.7979 seconds average (3.99 seconds / 5 examples) ./spec/cells/chapter_cell_spec.rb:6 - Decidim::Notify::ParticipantCell - 0.78534 seconds average (1.57 seconds / 2 examples) ./spec/cells/participant_cell_spec.rb:6 - Decidim::Notify::Admin::NotifyConfigForm - 0.76576 seconds average (0.76576 seconds / 1 example) ./spec/forms/admin/notify_config_form_spec.rb:6 - Decidim::Notify::Admin::ConversationsController - 0.54164 seconds average (1.62 seconds / 3 examples) ./spec/controllers/admin/conversations_controller_spec.rb:6 - Decidim::Notify::Chapter - 0.51141 seconds average (2.05 seconds / 4 examples) ./spec/models/chapter_spec.rb:7 - Decidim::Notify::ChaptersController - 0.43065 seconds average (0.8613 seconds / 2 examples) ./spec/controllers/chapters_controller_spec.rb:6 - -Finished in 41.58 seconds (files took 4.15 seconds to load) -57 examples, 2 failures - -Failed examples: - -rspec ./spec/cells/chapter_cell_spec.rb:36 # Decidim::Notify::ChapterCell when user is note_taker renders the edit button -rspec ./spec/cells/note_cell_spec.rb:36 # Decidim::Notify::NoteCell when user is note_taker renders the edit button - -Randomized with seed 4850 - - - _____ _ - / ____| | | -| | ___ __| | ___ ___ _____ __ -| | / _ \ / _\`|/ _ \/ __/ _ \ \ / / -| |___| (_) | (_| | __/ (_| (_) \ V / - \_____\___/ \__,_|\___|\___\___/ \_/ - Ruby-0.2.12 -x> No CI provider detected. -==> Appending file network -==> Gzipping contents -==> Uploading reports - url: https://codecov.io - query: token=secret&flags&package=ruby-0.2.12&branch=deps%2Fdecidim-0.28&commit=120d15ec21ff6c53d2748461e3ac384478bac419 -->  Pinging Codecov -https://codecov.io/upload/v4?token=secret&flags&package=ruby-0.2.12&branch=deps%2Fdecidim-0.28&commit=120d15ec21ff6c53d2748461e3ac384478bac419 -{"message":"Token required - not valid tokenless upload"} - From 509e5ee2da7c64fb5eb6b584e97d55dbf2857454 Mon Sep 17 00:00:00 2001 From: Harrison Hassig Date: Fri, 10 Jan 2025 09:32:57 +0100 Subject: [PATCH 03/11] Rollback ffi to 1.15.5 --- Gemfile.lock | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 9e62341..b93d87e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -364,16 +364,7 @@ GEM logger faraday-net_http (3.4.0) net-http (>= 0.5.0) - ffi (1.17.1-aarch64-linux-gnu) - ffi (1.17.1-aarch64-linux-musl) - ffi (1.17.1-arm-linux-gnu) - ffi (1.17.1-arm-linux-musl) - ffi (1.17.1-arm64-darwin) - ffi (1.17.1-x86-linux-gnu) - ffi (1.17.1-x86-linux-musl) - ffi (1.17.1-x86_64-darwin) - ffi (1.17.1-x86_64-linux-gnu) - ffi (1.17.1-x86_64-linux-musl) + ffi (1.15.5) file_validators (3.0.0) activemodel (>= 3.2) mime-types (>= 1.0) From 849d95ca367b5905c529aff0322cc24ca8889c52 Mon Sep 17 00:00:00 2001 From: Harrison Hassig Date: Fri, 10 Jan 2025 09:51:06 +0100 Subject: [PATCH 04/11] Rollback rubocop for factorybot --- Gemfile.lock | 61 +++++++++++++++++++++++++--------------------------- 1 file changed, 29 insertions(+), 32 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index b93d87e..ef6423c 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -264,10 +264,9 @@ GEM rspec-rails (~> 6.0) rspec-retry (~> 0.6.2) rspec_junit_formatter (~> 0.6.0) - rubocop (~> 1.50.0) - rubocop-faker (~> 1.1) - rubocop-rails (~> 2.19) - rubocop-rspec (~> 2.20) + rubocop (~> 1.28.0) + rubocop-rails (~> 2.14) + rubocop-rspec (~> 2.10) selenium-webdriver (~> 4.9) simplecov (~> 0.22.0) simplecov-cobertura (~> 2.1.0) @@ -364,7 +363,16 @@ GEM logger faraday-net_http (3.4.0) net-http (>= 0.5.0) - ffi (1.15.5) + ffi (1.17.1-aarch64-linux-gnu) + ffi (1.17.1-aarch64-linux-musl) + ffi (1.17.1-arm-linux-gnu) + ffi (1.17.1-arm-linux-musl) + ffi (1.17.1-arm64-darwin) + ffi (1.17.1-x86-linux-gnu) + ffi (1.17.1-x86-linux-musl) + ffi (1.17.1-x86_64-darwin) + ffi (1.17.1-x86_64-linux-gnu) + ffi (1.17.1-x86_64-linux-musl) file_validators (3.0.0) activemodel (>= 3.2) mime-types (>= 1.0) @@ -454,7 +462,7 @@ GEM listen (3.9.0) rb-fsevent (~> 0.10, >= 0.10.3) rb-inotify (~> 0.9, >= 0.9.10) - logger (1.6.4) + logger (1.6.5) loofah (2.24.0) crass (~> 1.0.2) nokogiri (>= 1.12.0) @@ -544,7 +552,7 @@ GEM activerecord (>= 5.2) request_store (~> 1.1) parallel (1.26.3) - parallel_tests (4.8.0) + parallel_tests (4.9.0) parallel parser (3.3.6.0) ast (~> 2.4.1) @@ -665,37 +673,26 @@ GEM rspec-support (3.13.2) rspec_junit_formatter (0.6.0) rspec-core (>= 2, < 4, != 2.12.0) - rubocop (1.50.2) - json (~> 2.3) + rubocop (1.28.2) parallel (~> 1.10) - parser (>= 3.2.0.0) + parser (>= 3.1.0.0) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) - rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.28.0, < 2.0) + rexml + rubocop-ast (>= 1.17.0, < 2.0) ruby-progressbar (~> 1.7) - unicode-display_width (>= 2.4.0, < 3.0) - rubocop-ast (1.37.0) - parser (>= 3.3.1.0) - rubocop-capybara (2.21.0) - rubocop (~> 1.41) - rubocop-factory_bot (2.26.0) - rubocop (~> 1.41) - rubocop-faker (1.2.0) + unicode-display_width (>= 1.4.0, < 3.0) + rubocop-ast (1.29.0) + parser (>= 3.2.1.0) + rubocop-faker (1.1.0) faker (>= 2.12.0) - rubocop (>= 1.13.0) - rubocop-rails (2.25.1) + rubocop (>= 0.82.0) + rubocop-rails (2.15.2) activesupport (>= 4.2.0) rack (>= 1.1) - rubocop (>= 1.33.0, < 2.0) - rubocop-ast (>= 1.31.1, < 2.0) - rubocop-rspec (2.31.0) - rubocop (~> 1.40) - rubocop-capybara (~> 2.17) - rubocop-factory_bot (~> 2.22) - rubocop-rspec_rails (~> 2.28) - rubocop-rspec_rails (2.29.0) - rubocop (~> 1.40) + rubocop (>= 1.7.0, < 2.0) + rubocop-rspec (2.11.1) + rubocop (~> 1.19) ruby-progressbar (1.13.0) ruby-vips (2.2.2) ffi (~> 1.12) @@ -841,4 +838,4 @@ RUBY VERSION ruby 3.1.1p18 BUNDLED WITH - 2.5.23 + 2.6.2 From f35ca275d7574ffa3bc7fa2926939729cd4909e3 Mon Sep 17 00:00:00 2001 From: Harrison Hassig Date: Fri, 10 Jan 2025 10:00:37 +0100 Subject: [PATCH 05/11] Rollback ffi to 1.15.5 --- Gemfile.lock | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index ef6423c..ed56574 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -363,16 +363,7 @@ GEM logger faraday-net_http (3.4.0) net-http (>= 0.5.0) - ffi (1.17.1-aarch64-linux-gnu) - ffi (1.17.1-aarch64-linux-musl) - ffi (1.17.1-arm-linux-gnu) - ffi (1.17.1-arm-linux-musl) - ffi (1.17.1-arm64-darwin) - ffi (1.17.1-x86-linux-gnu) - ffi (1.17.1-x86-linux-musl) - ffi (1.17.1-x86_64-darwin) - ffi (1.17.1-x86_64-linux-gnu) - ffi (1.17.1-x86_64-linux-musl) + ffi (1.15.1) file_validators (3.0.0) activemodel (>= 3.2) mime-types (>= 1.0) From 5fa6575c55e03d97af9667a30ea1aeb3faa1db65 Mon Sep 17 00:00:00 2001 From: Harrison Hassig Date: Mon, 13 Jan 2025 16:56:11 +0100 Subject: [PATCH 06/11] Remove unwanted imported stylesheets --- app/cells/decidim/notify/chapter/show.erb | 2 +- app/cells/decidim/notify/note/show.erb | 2 +- app/packs/src/decidim/notify/notify_selects.js | 6 +++--- app/packs/stylesheets/decidim/notify/admin.scss | 4 ---- app/packs/stylesheets/decidim/notify/notify.scss | 8 +------- .../decidim/notify/admin/conversations/index.html.erb | 2 +- app/views/decidim/notify/conversations/index.html.erb | 2 +- config/assets.rb | 2 +- 8 files changed, 9 insertions(+), 19 deletions(-) diff --git a/app/cells/decidim/notify/chapter/show.erb b/app/cells/decidim/notify/chapter/show.erb index ceed445..31e005e 100644 --- a/app/cells/decidim/notify/chapter/show.erb +++ b/app/cells/decidim/notify/chapter/show.erb @@ -3,7 +3,7 @@

"> <%= title %> <% if note_taker? %> - + <% end %> diff --git a/app/packs/src/decidim/notify/notify_selects.js b/app/packs/src/decidim/notify/notify_selects.js index 5b738aa..f839ac4 100644 --- a/app/packs/src/decidim/notify/notify_selects.js +++ b/app/packs/src/decidim/notify/notify_selects.js @@ -1,5 +1,5 @@ // I haven't found a way to include jquery plugins without making webpack repeat jQuery itself -// the workaround is to use CDN providers and include them via standard