Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor snakefile #135

Open
fhg-isi opened this issue Jul 11, 2024 · 0 comments
Open

Refactor snakefile #135

fhg-isi opened this issue Jul 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@fhg-isi
Copy link
Contributor

fhg-isi commented Jul 11, 2024

Some suggestions:

b) Remove the out commented section convert_fraunhofer from the Snakefile (we have version control, don't we?) or comment its meaning.

c) Use snake_case naming conventions for rule names => convert_ewg instead of convert_EWG?

d) rename rule and script compile_cost_assumptions to main to clarify what part is the main script / entry point.

e) Clarify if project is

  1. only about cost or if
  2. it also contains other data.

If 1. maybe rename project to technology-cost
If 2. maybe rename output files to outputs/technology_{year}.csv

@fhg-isi fhg-isi added the enhancement New feature or request label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant