Skip to content
This repository has been archived by the owner on Dec 9, 2023. It is now read-only.

Fix TransferCommand::Combine CLI command (NoOutpoint error) #200

Open
zoedberg opened this issue Sep 12, 2022 · 0 comments
Open

Fix TransferCommand::Combine CLI command (NoOutpoint error) #200

zoedberg opened this issue Sep 12, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@zoedberg
Copy link
Contributor

reporting an issue mentioned in #196:

The TransferCommand::Combine CLI command seems to have a bug: let blank_bundle = TransitionBundle::blank(&outpoint_map, &bmap! {})?; will always receive a NoOutpoint error, since the TransitionBundle::blank method expects to find at least an outpoint in it:

let (op, close_method) = new_outpoints
    .get(&input.ty)
    .ok_or(Error::NoOutpoint(input.ty))?;

So we cannot provide an empty bmap for the new_outpoints parameter.

As said in this comment #196 (comment) we should allow the specification of new outpoints via CLI, eventually failing back to the change outpoint if those are not provided

@dr-orlovsky dr-orlovsky self-assigned this Nov 16, 2022
@dr-orlovsky dr-orlovsky added the bug Something isn't working label Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants