Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history: RGB change doesn't show up #282

Closed
zoedberg opened this issue Oct 31, 2024 · 5 comments
Closed

history: RGB change doesn't show up #282

zoedberg opened this issue Oct 31, 2024 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@zoedberg
Copy link
Contributor

When calling the wallet history APIs, the RGB change doesn't show up.

@dr-orlovsky
Copy link
Member

What do you mean by "change"? History shows just operations, and there is no such thing as "change operation". Do you mean that the last operation in the history is not shown - or something else?

@dr-orlovsky dr-orlovsky self-assigned this Oct 31, 2024
@dr-orlovsky dr-orlovsky moved this to Ready in RGB release v0.11 Oct 31, 2024
@zoedberg
Copy link
Contributor Author

I mean that after a wallet sends some RGB assets it will see the operation with the sent amount but no operation for the change amount.

@dr-orlovsky
Copy link
Member

But there must be no operation with a change amount since the change is not an operation at all!

@dr-orlovsky dr-orlovsky added the question Further information is requested label Nov 1, 2024
@zoedberg
Copy link
Contributor Author

zoedberg commented Nov 1, 2024

I thought a change should appear as an operation with OpDirection::Received, but probably I misunderstood the desired behavior of the history API.

Not sure it's related to this (I thought so but I'm not sure anymore): running the send_to_oneself test (introduced in RGB-WG/rgb-tests#3) with the updated code you'll see only the issued operation after the send. Is this the intended behavior?

@dr-orlovsky
Copy link
Member

Is this the intended behavior?

Yes. History is for humans, meaning they need to see incoming and outgoing funds, not self-transfers or change

@zoedberg zoedberg closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in RGB release v0.11 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Done
Development

No branches or pull requests

2 participants