Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider removing the "Go!" button #160

Open
cjyetman opened this issue Dec 11, 2024 · 4 comments
Open

consider removing the "Go!" button #160

cjyetman opened this issue Dec 11, 2024 · 4 comments
Assignees

Comments

@cjyetman
Copy link
Member

It seems awkward to require clicking the "Go!" button to see the results, especially when the sector and investment type selectors have already defaulted to some value. Could we have it "go" automatically to whatever the default values for the selectors have?

@jdhoffa
Copy link
Member

jdhoffa commented Dec 11, 2024

The "Go!" button was actually specifically requested and thoughtfully designed towards the user experience.
I will let @MonikaFu speak more to it and why it was deemed necessary, but I think we are unlikely to remove it

@cjyetman
Copy link
Member Author

ok... I'm predicting that it will conflict with resolving these issues

@jdhoffa
Copy link
Member

jdhoffa commented Dec 11, 2024

Interesting!! Thank you for the heads up

@MonikaFu
Copy link
Contributor

MonikaFu commented Jan 8, 2025

Indeed the 'Go!' button was considered necessary as we want to make sure that the user is aware that they can choose an asset class and sector to view. There was a worry that if we directly show results for one asset class and one sector some users might now realize they can see results for other sectors/asset classes as well. Apparently that was the case for the interactive report.

I believe what is cumbersome right now is that the user needs to make a selection each time they change a tab which is a different problem and it is captured in #144. If we can solve that issue then I don't think that #145 will be conflicting with the existence of the button. We could add a state to URL (if it is at all possible) indicating if the first selection was made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants