Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R CMD check failing on main #70

Open
jdhoffa opened this issue Oct 30, 2024 · 2 comments
Open

R CMD check failing on main #70

jdhoffa opened this issue Oct 30, 2024 · 2 comments
Labels
breaking change ☠️ API change likely to affect existing code bug an unexpected problem or unintended behavior upkeep maintenance, infrastructure, and similar

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Oct 30, 2024

See:
https://github.com/RMI-PACTA/pacta.data.scraping/actions/workflows/R-CMD-check.yaml

Or:
https://github.com/RMI-PACTA/pacta.data.scraping/actions/runs/11549775632
@jdhoffa jdhoffa added upkeep maintenance, infrastructure, and similar bug an unexpected problem or unintended behavior labels Oct 30, 2024
@cjyetman
Copy link
Member

both source URLs have changed or their content has changed. not sure if/when it makes sense to "fix" it

@jdhoffa jdhoffa added the breaking change ☠️ API change likely to affect existing code label Oct 30, 2024
@jdhoffa
Copy link
Member Author

jdhoffa commented Oct 30, 2024

Agreed, it doesn't seem efficient to tackle this urgently now, in case they just go ahead and shift the URLs and content structure again...

I've tagged it appropriately. Will be something we prioritize if/ when we come back to running data prep in the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change ☠️ API change likely to affect existing code bug an unexpected problem or unintended behavior upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjyetman @jdhoffa