-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtle table cell borders #59
Comments
To send a message, edit "activationEvents": [
"onRenderer:vscode-data-table"
],
"contributes": {
"notebookRenderer": [
{
"id": "vscode-data-table",
// ...
"requiresMessaging": "optional",// <==
}
]
} In const rendererMessaging = notebooks.createRendererMessaging('vscode-data-table');
rendererMessaging.onDidReceiveMessage(handleMessage);
function handleMessage(msg: any) {
} In context.postMessage?.('msg'); |
let's wait till vscode v1.59 is released to implement these changes. I'll update vscode dev dependencies and notebook api libs in #63 for now, if that helps. |
@usernamehw I am closing this since built-in vscode table styles also use alternating row bg colors and no borders either. I think doing both is too much cognitively, and not worth the extra effort for the current data table display. |
see #57
Alternatively, default to table display without cell borders display for cleaner data view and let users change it via
data.table.cell.border = true
or similar setting.Ideally, we would add
data.table
settings change handler inextension.ts
and createconfig.ts
similar to how we did it in snippets viewer for us to load this and table height setting described in #55see: https://github.com/RandomFractals/vscode-snippets-viewer/blob/main/src/config.ts
The text was updated successfully, but these errors were encountered: