Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtle table cell borders #59

Closed
RandomFractals opened this issue Jul 25, 2021 · 3 comments
Closed

Add subtle table cell borders #59

RandomFractals opened this issue Jul 25, 2021 · 3 comments
Labels
enhancement Feature enhancement

Comments

@RandomFractals
Copy link
Owner

RandomFractals commented Jul 25, 2021

see #57

Alternatively, default to table display without cell borders display for cleaner data view and let users change it via data.table.cell.border = true or similar setting.

Ideally, we would add data.table settings change handler in extension.ts and create config.ts similar to how we did it in snippets viewer for us to load this and table height setting described in #55

see: https://github.com/RandomFractals/vscode-snippets-viewer/blob/main/src/config.ts

@usernamehw
Copy link
Collaborator

usernamehw commented Jul 25, 2021

createRendererMessaging requires proposed api enabled. It will be Stable after 1.59.

To send a message, edit package.json:

"activationEvents": [
  "onRenderer:vscode-data-table"
],
"contributes": {
    "notebookRenderer": [
      {
        "id": "vscode-data-table",
        // ...
        "requiresMessaging": "optional",// <==
      }
    ]
}

In extension.ts

const rendererMessaging = notebooks.createRendererMessaging('vscode-data-table');
rendererMessaging.onDidReceiveMessage(handleMessage);
function handleMessage(msg: any) {

}

In renderer/index.ts

context.postMessage?.('msg');

@RandomFractals
Copy link
Owner Author

RandomFractals commented Jul 25, 2021

let's wait till vscode v1.59 is released to implement these changes.

I'll update vscode dev dependencies and notebook api libs in #63 for now, if that helps.

@RandomFractals
Copy link
Owner Author

@usernamehw I am closing this since built-in vscode table styles also use alternating row bg colors and no borders either. I think doing both is too much cognitively, and not worth the extra effort for the current data table display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature enhancement
Projects
None yet
Development

No branches or pull requests

2 participants