Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainScreenView is recomposing every time when user comes back from DetailScreen #55

Open
Sushant-Hande opened this issue Dec 15, 2024 · 2 comments · May be fixed by #58
Open

MainScreenView is recomposing every time when user comes back from DetailScreen #55

Sushant-Hande opened this issue Dec 15, 2024 · 2 comments · May be fixed by #58

Comments

@Sushant-Hande
Copy link
Contributor

Hi @SEAbdulbasit,
Currently, when the user comes back from DetailScreen to MainScreenView, it recomposes MainScreenView every time. This resulting into inconsistent UI state. This is probably due to the manual navigation to composable screens. I could see in MainView.kt file some code is commented that handles navigation using Jetpack Navigation.

I wanted to discuss that, can we uncomment this code or any other scenario is there due to which it is commented?

@SEAbdulbasit
Copy link
Owner

SEAbdulbasit commented Dec 20, 2024

Hmm, now i forgot why i commented this code.
Can you give it a try and see if there is any side effect ?

@Sushant-Hande
Copy link
Contributor Author

Thanks. I will uncomment that piece of code and if everything works fine, will create a pull request for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants