Updated screen navigation with jetpack navigation library implementation #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issues & Documents
Fixes #55
Description
Hi @SEAbdulbasit,
Earlier, when the user use to comes back from DetailScreen to MainScreenView, it was recomposing MainScreenView every time. This was resulting into inconsistent UI state and user experience. Now, after updating the navigation logic with Jetpack navigation code, that was commented earlier, it is working fine and the UI contents appearing as expected.
Code Changes
In MainView.kt file, manual navigation logic updated with Jetpack navigation code.
Screenshots, Recordings
Before change
manual-navigation-android.webm
manual-navigation-iOS.mp4
After change
jetpack-navigation-android.webm
jetpack-navigation-iOS.mp4