diff --git a/dependencies/nx_kit/CMakeLists.txt b/dependencies/nx_kit/CMakeLists.txt index 0ccba73..6735901 100644 --- a/dependencies/nx_kit/CMakeLists.txt +++ b/dependencies/nx_kit/CMakeLists.txt @@ -80,6 +80,11 @@ if(MSVC) # This block covers not only Visual Studio compiler but also clang-cl, which expands /W4 to # the -Wall flag, while -Wall itself, if passed directly, will be expanded to -Weverything. add_compile_options(/W4 /WX /utf-8) + + # Temporary fix to prevent crashes on startup of Network Optix Server + # Issue causes by compiling with MSVC 14.40 which has a code change incompatible + # with MSVC 14.38 which the Network Optix server is compiled with. + add_compile_definitions(_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR) elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang") add_compile_options(-Wall -Wextra -Werror) endif() diff --git a/dependencies/nx_kit/src/nx/kit/debug.cpp b/dependencies/nx_kit/src/nx/kit/debug.cpp index 63e4300..330a6f3 100644 --- a/dependencies/nx_kit/src/nx/kit/debug.cpp +++ b/dependencies/nx_kit/src/nx/kit/debug.cpp @@ -2,15 +2,6 @@ #include "debug.h" -// Temporary fix to prevent crashes on startup of Network Optix Server -// Issue causes by compiling with MSVC 14.40 which has a code change incompatible -// with MSVC 14.38 which the Network Optix server is compiled with. -#if defined(_WIN32) -#ifndef _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#endif -#endif - #include #include #include diff --git a/dependencies/nx_kit/src/nx/kit/ini_config.cpp b/dependencies/nx_kit/src/nx/kit/ini_config.cpp index 48240f9..c6add0b 100644 --- a/dependencies/nx_kit/src/nx/kit/ini_config.cpp +++ b/dependencies/nx_kit/src/nx/kit/ini_config.cpp @@ -2,15 +2,6 @@ #include "ini_config.h" -// Temporary fix to prevent crashes on startup of Network Optix Server -// Issue causes by compiling with MSVC 14.40 which has a code change incompatible -// with MSVC 14.38 which the Network Optix server is compiled with. -#if defined(_WIN32) -#ifndef _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#endif -#endif - #include #include #include diff --git a/dependencies/nx_kit/src/nx/kit/ini_config.h b/dependencies/nx_kit/src/nx/kit/ini_config.h index 05c9eaf..e9035fa 100644 --- a/dependencies/nx_kit/src/nx/kit/ini_config.h +++ b/dependencies/nx_kit/src/nx/kit/ini_config.h @@ -2,15 +2,6 @@ #pragma once -// Temporary fix to prevent crashes on startup of Network Optix Server -// Issue causes by compiling with MSVC 14.40 which has a code change incompatible -// with MSVC 14.38 which the Network Optix server is compiled with. -#if defined(_WIN32) -#ifndef _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#endif -#endif - #include #include #include diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index ebfd803..45de61e 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -98,6 +98,11 @@ if(NOT MSVC) -Werror=format-security ) else() + # Temporary fix to prevent crashes on startup of Network Optix Server + # Issue causes by compiling with MSVC 14.40 which has a code change incompatible + # with MSVC 14.38 which the Network Optix server is compiled with. + add_compile_definitions(_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR) + add_compile_definitions(_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING) target_compile_options(cloudfuse_plugin PRIVATE -W4 -GS -sdl diff --git a/src/lib/nx/sdk/analytics/helpers/consuming_device_agent.h b/src/lib/nx/sdk/analytics/helpers/consuming_device_agent.h index 3d9aa84..e1bbbb9 100644 --- a/src/lib/nx/sdk/analytics/helpers/consuming_device_agent.h +++ b/src/lib/nx/sdk/analytics/helpers/consuming_device_agent.h @@ -2,15 +2,6 @@ #pragma once -// Temporary fix to prevent crashes on startup of Network Optix Server -// Issue causes by compiling with MSVC 14.40 which has a code change incompatible -// with MSVC 14.38 which the Network Optix server is compiled with. -#if defined(_WIN32) -#ifndef _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#endif -#endif - #include #include #include diff --git a/src/lib/nx/sdk/analytics/helpers/engine.h b/src/lib/nx/sdk/analytics/helpers/engine.h index 8ec6ffa..0e543f0 100644 --- a/src/lib/nx/sdk/analytics/helpers/engine.h +++ b/src/lib/nx/sdk/analytics/helpers/engine.h @@ -2,14 +2,6 @@ #pragma once -// Temporary fix to prevent crashes on startup of Network Optix Server -// Issue causes by compiling with MSVC 14.40 which has a code change incompatible -// with MSVC 14.38 which the Network Optix server is compiled with. -#if defined(_WIN32) -#ifndef _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#endif -#endif #include #include #include diff --git a/src/lib/nx/sdk/helpers/lib_context.h b/src/lib/nx/sdk/helpers/lib_context.h index dc8d807..dd3662e 100644 --- a/src/lib/nx/sdk/helpers/lib_context.h +++ b/src/lib/nx/sdk/helpers/lib_context.h @@ -2,15 +2,6 @@ #pragma once -// Temporary fix to prevent crashes on startup of Network Optix Server -// Issue causes by compiling with MSVC 14.40 which has a code change incompatible -// with MSVC 14.38 which the Network Optix server is compiled with. -#if defined(_WIN32) -#ifndef _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#endif -#endif - #include #include #include diff --git a/src/lib/nx/sdk/helpers/media_stream_statistics.h b/src/lib/nx/sdk/helpers/media_stream_statistics.h index f47207b..3438918 100644 --- a/src/lib/nx/sdk/helpers/media_stream_statistics.h +++ b/src/lib/nx/sdk/helpers/media_stream_statistics.h @@ -2,15 +2,6 @@ #pragma once -// Temporary fix to prevent crashes on startup of Network Optix Server -// Issue causes by compiling with MSVC 14.40 which has a code change incompatible -// with MSVC 14.38 which the Network Optix server is compiled with. -#if defined(_WIN32) -#ifndef _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#endif -#endif - #include #include #include diff --git a/src/lib/nx/sdk/helpers/uuid_helper.cpp b/src/lib/nx/sdk/helpers/uuid_helper.cpp index ee13e1c..b053312 100644 --- a/src/lib/nx/sdk/helpers/uuid_helper.cpp +++ b/src/lib/nx/sdk/helpers/uuid_helper.cpp @@ -2,15 +2,6 @@ #include "uuid_helper.h" -// Temporary fix to prevent crashes on startup of Network Optix Server -// Issue causes by compiling with MSVC 14.40 which has a code change incompatible -// with MSVC 14.38 which the Network Optix server is compiled with. -#if defined(_WIN32) -#ifndef _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR -#endif -#endif - #include #include #include diff --git a/src/vcpkg.json b/src/vcpkg.json index 49179d1..58d7c60 100644 --- a/src/vcpkg.json +++ b/src/vcpkg.json @@ -1,7 +1,7 @@ { "name": "nx-lyve-cloud-plugin", "dependencies": [ - { "name": "openssl", "version>=": "3.3.1" } + { "name": "openssl", "version>=": "3.3.2" } ], - "builtin-baseline": "4065f37d0a6628ef17cf6ee15385f9091f1075bc" + "builtin-baseline": "b2cb0da531c2f1f740045bfe7c4dac59f0b2b69c" }