Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

pt estimate for T5s in parseT5 function is deprecated #249

Closed
jkguiang opened this issue Mar 1, 2023 · 2 comments
Closed

pt estimate for T5s in parseT5 function is deprecated #249

jkguiang opened this issue Mar 1, 2023 · 2 comments

Comments

@jkguiang
Copy link
Contributor

jkguiang commented Mar 1, 2023

The pT for T5s in the output NTuple are computed as follows:

float pt = quintupletsInGPU.innerRadius[quintupletIndex] * kRinv1GeVf;
...
ana.tx->pushbackToBranch<float>("t5_pt", pt);

However, the pT estimate in parseT5 is just the average of the T3 pT's (which is somewhat questionable per #214):

// Compute pt estimates from inner and outer triplets
const float ptAv_in = abs(dr_in * k2Rinv1GeVf / sin((betaIn_in + betaOut_in) / 2.));
const float ptAv_out = abs(dr_out * k2Rinv1GeVf / sin((betaIn_out + betaOut_out) / 2.));

// T5 pt is average of the two pt estimates
const float pt = (ptAv_in + ptAv_out) / 2.;

It's my understanding that the pT as computed for the T5s in the output NTuple are "more correct," and that both the pTs from the output NTuple and parseT5 are used and therefore giving inconsistent results. I am working on a PR (will include link here when available) that will add some additional branches for the GNN NTuple, so I can make the fix in that PR as well if desired.

@VourMa
Copy link
Contributor

VourMa commented Oct 29, 2023

@jkguiang Is this still an issue? Did you deal with it in any of your PRs,as mentioned in the description?

@VourMa
Copy link
Contributor

VourMa commented Apr 21, 2024

Closed by #388

@VourMa VourMa closed this as completed Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants