chore: add dummy jwt secret #6780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue/pr! |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9f4af9f in 1 minute and 43 seconds
More details
- Looked at
46lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. ee/query-service/main.go:184
- Draft comment:
Using a hardcoded dummy JWT secret is a security risk. Ensure this is only used for development and not in production environments. - Reason this comment was not posted:
Comment did not seem useful.
2. pkg/query-service/main.go:102
- Draft comment:
Using a hardcoded dummy JWT secret is a security risk. Ensure this is only used for development and not in production environments. - Reason this comment was not posted:
Marked as duplicate.
3. pkg/query-service/constants/auth.go:7
- Draft comment:
Use design tokens or predefined color constants instead of hardcoding color values to maintain consistency in design and theming. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_nViP1FFGdflnenDl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6763
Currently if JWT_SECRET is not setup through env variable, it breaks the frontend.
Important
Adds a dummy JWT secret to be used if no JWT secret is specified, with warnings logged for production environments.
SIGNOZ_JWT_SECRETinauth.goto be used if no JWT secret is specified.main.goin bothee/query-serviceandpkg/query-serviceto setauth.JwtSecrettoSIGNOZ_JWT_SECRETif the environment variableSIGNOZ_JWT_SECRETis not set.This description was created by
for 9f4af9f. It will automatically update as commits are pushed.