Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak Application TRACKING ISSUE #3949

Open
powpingdone opened this issue Feb 3, 2024 · 58 comments
Open

Flatpak Application TRACKING ISSUE #3949

powpingdone opened this issue Feb 3, 2024 · 58 comments

Comments

@powpingdone
Copy link
Contributor

powpingdone commented Feb 3, 2024

This is a tracking issue for the flatpak build of orcaslicer, as there are a few specific bugs that must be fixed in order to consider the build working properly.

Original Issue Description

I am requesting permission to create a Flatpak application (manifest here), along with any modifications required by other contributors. Given permission, I will go on to flathub and publish the application.

@powpingdone
Copy link
Contributor Author

@SoftFever I'm very sorry for pinging you, but I would like your "ok" on this.

@SoftFever
Copy link
Owner

Hi @powpingdone

First thing first, that's great!

Could you please clarify what permission you are asking for? At the moment, Orca's CICD only creates appimages.
If you are working on building or GitHub actions scripts, would you mind submitting a pull request? Please let me know if you meant something else.

@powpingdone
Copy link
Contributor Author

powpingdone commented Feb 5, 2024

From https://docs.flathub.org/docs/for-app-authors/submission#theres-an-app-that-id-like-to-see-on-flathub-but-im-not-the-developer

If there’s an app that you'd like to be distributed on Flathub, the best first course of action is to approach the app’s developers and ask them to submit it. Remember that for some projects or communities, this may be the first that they have heard of the Flatpak technology or interacted with somebody who advocates it. When you are making such requests, please be aware that the people you are talking to may be forming their first impressions of Flatpak as a technology and a community.

I could do initial distribution of both nightly, and (eventually) stable releases past v2 (due to that flatpak patch needed) without using CI, but since I'm not the owner of the repository I would like your permission to operate this.

@powpingdone
Copy link
Contributor Author

I'm not asking you to submit a flatpak, I would be doing that myself (with input from you and other devs).

@SoftFever
Copy link
Owner

From https://docs.flathub.org/docs/for-app-authors/submission#theres-an-app-that-id-like-to-see-on-flathub-but-im-not-the-developer

If there’s an app that you'd like to be distributed on Flathub, the best first course of action is to approach the app’s developers and ask them to submit it. Remember that for some projects or communities, this may be the first that they have heard of the Flatpak technology or interacted with somebody who advocates it. When you are making such requests, please be aware that the people you are talking to may be forming their first impressions of Flatpak as a technology and a community.

I could do initial distribution of both nightly, and (eventually) stable releases past v2 (due to that flatpak patch needed) without using CI, but since I'm not the owner of the repository I would like your permission to operate this.

Thanks for the explanation.

Currently, all OrcaSlicer builds, including the official releases, are fully automated within this GitHub repository and it's CI/CD pipeline to ensure security.
I intend to maintain this approach for any new distribution formats, purely from a security and maintenance perspective.
I hope you can understand my rationale.

@powpingdone
Copy link
Contributor Author

powpingdone commented Feb 5, 2024

That's completely understandable. Shall I setup/pr a CI job to distribute a flatpak then? I would have to give you a key as a secret to allow uploading to flathub.

@SoftFever
Copy link
Owner

That's completely understandable. Shall I setup/pr a CI job to distribute a flatpak then? I would have to give you a key as a secret to allow uploading to flathub.

👍
That would be great!

@ClaytonRehder
Copy link

ClaytonRehder commented Feb 7, 2024

+1. Good initiative. There are a lot of Linux distros that will appreciate.

@powpingdone
Copy link
Contributor Author

Note to self, from the flatpak matrix

start from adding a CI job producing bundles, and when you have that, we can sort out the rest

@tapir
Copy link

tapir commented Feb 11, 2024

this is great! can we not wait for 2.0 and just have one for 1.9 already?

@powpingdone
Copy link
Contributor Author

@tapir afaict, because of the flatpak specific patches, no.

@hadess
Copy link
Contributor

hadess commented Feb 26, 2024

I am requesting permission to create a Flatpak application (manifest here), along with any modifications required by other contributors. Given permission, I will go on to flathub and publish the application.

That manifest looks eerily familiar ;)

Let me know if you think there's anything we could do to make it easier to share between the 2 manifests repositories, once this has landed, and please CC: me on the Flathub review as well.

@powpingdone
Copy link
Contributor Author

shhhh I totally didn't do anything to it :P

@kugelzucker
Copy link

so as it happens i just opened the orcaslicer github page to check if there was a release for 2.0 since bambustudio messed up some tree supports. 6 minutes ago was the release of 2.0, i am in luck.

since this is an open source project and devs are always very interested in annoying and pushy comments i thought i would do my part and ask:

why is there no flatpak released 6 minutes after the official release? i cant believe it.

seriously though, what is the process and how can we help? is this already implemented and the pipeline is just slower (6 minutes, i mean cmon ... :D)?

thanks for all your great work!

@powpingdone
Copy link
Contributor Author

@kugelzucker currently i'm bogged down by irl stuff and ci is failing for reasons unknown (when it was previously fine).

@kugelzucker
Copy link

im giving this a nudge, checking in

@kugelzucker
Copy link

kugelzucker commented May 13, 2024

im giving this a nudge, checking in

also, this builds and installs fine for me. fyi (and yes i know that CI is different ;))

@powpingdone
Copy link
Contributor Author

@kugelzucker tl;dr: this messes with a lot of dep resolution stuff so it gets messy on other systems. it's fine for flatpak, but it's not fine for literally everyone else

@powpingdone
Copy link
Contributor Author

Update for everyone who is following this but not the PR: #4175 has been merged. Next up, Softfever and I will have to get in contact with Flathub to get the necessary things (api keys) to upload from CI.

@powpingdone
Copy link
Contributor Author

cc #5449

@powpingdone
Copy link
Contributor Author

cc #5474

@powpingdone powpingdone changed the title Flatpak Application Flatpak Application TRACKING ISSUE May 29, 2024
@cochcoder
Copy link
Contributor

I'd also like to note that you may want to build the flatpak with freedesktop-22.08 rather than gnome-45, as freedesktop prioritizes having applications work consistently on all platforms rather than one. I also noticed in my testing that building with freedesktop causes the flatpak to have a slightly smaller size and uses less ram than the gnome build.

@powpingdone
Copy link
Contributor Author

powpingdone commented Jun 16, 2024

@hgelpke cross quoting from pr:

Can somebody give a rundown on how to build this? Tried on Fedora 40 and failed but it is also the first time I'm trying this.

tldr: flatpak-builder --force-clean --user --install --jobs=2 builddir io.github.softfever.OrcaSlicer.yml.
Adjust --jobs= to fit in RAM, as a single compile job in OrcaSlicer can take up 4GB ram or more.
Build is currently broken and i'm investigating in #5510.

@hgelpke
Copy link

hgelpke commented Jul 9, 2024

@hgelpke cross quoting from pr:

Can somebody give a rundown on how to build this? Tried on Fedora 40 and failed but it is also the first time I'm trying this.

tldr: flatpak-builder --force-clean --user --install --jobs=2 builddir io.github.softfever.OrcaSlicer.yml. Adjust --jobs= to fit in RAM, as a single compile job in OrcaSlicer can take up 4GB ram or more. Build is currently broken and i'm investigating in #5510.

Great! Thanks for the reply and apologies for missing it. Good luck on the fix and I appreciate your efforts

@powpingdone
Copy link
Contributor Author

Ok, after the cmake fiasco we're now in the tree. Finally. Going to file an issue to flathub soon(tm).

@albei
Copy link

albei commented Jul 18, 2024

P1S camera still not working Flatpak 2.1.1 Build all #2600
Testing it on a fedora silverblue.
"Player is malfunctioning. Please reinstall the system player. [2:2]"
Even so we finally have a flatpak! Many thanks for your effort !

PS: Also testing the official bambulab studio and the camera works.

@powpingdone
Copy link
Contributor Author

@SoftFever bump, waiting for your input.

@Ziomal12
Copy link

Ziomal12 commented Oct 8, 2024

Has anyone got working flatpak of 2.2?

@cochcoder
Copy link
Contributor

@powpingdone

I don't mean to be that person, but do you know when we could get a working GitHub action for the flatpak?

@anarsoul
Copy link
Contributor

@SoftFever sorry for nagging you, but could we please get an approval for building flatpak externally?

It would simplify installation of Orca Slicer for a lot of Linux users and personally I don't see any drawbacks for you, only benefits.

Flatpak runtime environment is more contained than any Linux distro, so Orca Slicer will be running more stable and it would be easier to reproduce bugs if there are any.

@Ziomal12
Copy link

@anarsoul Correct me if I'm wrong but as far as I understand under AGPL-3.0 licence distribution of the software is allowed as you disclose source and use the same licence as original.

@anarsoul
Copy link
Contributor

@Ziomal12 see flathub submission guide: https://docs.flathub.org/docs/for-app-authors/submission/#theres-an-app-that-id-like-to-see-on-flathub-but-im-not-the-developer

We are at the step one. Submitting it without author's approval is the last resort.

@ChaosBlades
Copy link

@anarsoul Try emailing or DM on X. Notification is probably just not getting through or lost in everything else going on.

@cochcoder
Copy link
Contributor

@ChaosBlades
It's only been 12 hours, give SoftFever some time. Both SoftFever and PowPingDone are really busy.

@tapir
Copy link

tapir commented Oct 25, 2024

@cochcoder we haven't heard from him on this thread since Aug. That's probably what @ChaosBlades meant.

@anarsoul
Copy link
Contributor

anarsoul commented Oct 27, 2024

I created a repo with (fixed) flatpak manifest for OrcaSlicer: https://github.com/anarsoul/io.github.softfever.OrcaSlicer

Flatpak for v2.2.0 can be found here: https://github.com/anarsoul/io.github.softfever.OrcaSlicer/releases/tag/v2.2.0-1

@cochcoder
Copy link
Contributor

@anarsoul

Do you think you'll be able to make a PR with the manifest fixes?

@anarsoul
Copy link
Contributor

anarsoul commented Oct 27, 2024

@cochcoder I can, although it won't help with getting flatpak into flathub.

One of the fixes has been sitting in review for 3 weeks: #7057

The other fix is getting rid of python script and integrating dark theme detection into wxWidgets (see the patch in my repo, I took it from bambulab slicer manifest repo)

@cochcoder
Copy link
Contributor

@cochcoder I can, although it won't help with getting flatpak into flathub.

That's fine, we would've need to get a working flatpak first anyways.

One of the fixes has been sitting in review for 3 weeks: #7057

The other fix is getting rid of python script and integrating dark theme detection into wxWidgets (see the patch in my repo, I took it from bambulab slicer manifest repo)

You could link to those in your PR and mention that they need to get merged alongside the manifest fixes.

@hadess
Copy link
Contributor

hadess commented Oct 28, 2024

One of the fixes has been sitting in review for 3 weeks: #7057

This is what the build fixes that go into Bambu Studio look like:
bambulab/BambuStudio#5025

If the OrcaSlicer devs are anything like me, they're probably expecting better commit messages.

The other fix is getting rid of python script and integrating dark theme detection into wxWidgets (see the patch in my repo, I took it from bambulab slicer manifest repo)

You're welcome ;)

@anarsoul
Copy link
Contributor

anarsoul commented Oct 28, 2024

If the OrcaSlicer devs are anything like me, they're probably expecting better commit messages.

It's not my PR, but if OrcaSlicer devs were anything like me, they'd probably fix up commit message if they don't like it and merge the PR :)

@trebory6
Copy link

trebory6 commented Nov 18, 2024

@ChaosBlades It's only been 12 hours, give SoftFever some time. Both SoftFever and PowPingDone are really busy.

It's been 3 weeks, is that enough time? haha

Seriously though, it's disappointing that flatpak compatibility is taking so long officially. I'm getting very tired of bandaging Orcaslicer's appimage with environment variables after it breaks with each new Kernel update.

I jest! Thanks all for all the hard work.

@anarsoul
Copy link
Contributor

anarsoul commented Nov 18, 2024

Seriously though, it's disappointing that flatpak compatibility is taking so long officially. I'm getting very tired of bandaging Orcaslicer's appimage with environment variables after it breaks with each new Kernel update.

Just install flatpak from https://github.com/anarsoul/io.github.softfever.OrcaSlicer/releases/tag/v2.2.0-2

@anarsoul
Copy link
Contributor

@SoftFever sorry to nag you again, but can we get this issue moving? If you need to discuss it further in real-time, text or voice, I'm available in discord on Orca Slicer server, same nickname as here.

@Skaifer
Copy link

Skaifer commented Dec 4, 2024

@anarsoul Feels so right to install a flatpak. I have issue though with flatpak version as well. The preview side is all gray. Tried to set env variables as for appimage, but that doesn't do anything or makes things worse. And appimage currently runs with those fixes, but preview is terribly slow.

P.S.
Sorry, the link had broken, cuz the service deleted the output. Here is terminal output on Pastebin.

@Jookia
Copy link

Jookia commented Dec 4, 2024

As a user I would really appreciate an official Flathub package even if it's not created by the OrcaSlicer devs.

Long term this might be the more secure option too: Right now to run OrcaSlicer I have to download binaries with no way or ability to check if they're built from corresponding source code. I can't even check if the binaries are the ones the developer uploaded, there's no package signing.

Having an independent third party such as Flathub build and distribute binaries based on a manifest would give me an ability to trust the version of OrcaSlicer I'm running.

@Skaifer
Copy link

Skaifer commented Dec 20, 2024

Ran Flatpak version successfully on Bazzite under Wayland, thanks to Fr0sty4 comment:

For anyone using the flatpak -- adding this environment variable via Flatseal should work for software rendering and stays inside the flatpak:

__EGL_VENDOR_LIBRARY_FILENAMES=/usr/lib/x86_64-linux-gnu/GL/default/share/glvnd/egl_vendor.d/50_mesa.json

The thing, that's different from previous variable, is the path to 50_mesa.json, which previously was /usr/share/glvnd/egl_vendor.d/50_mesa.json. I checked the new path, and there is nothing. Basically giving it nothing fixed the issue, which is weird, but I digress. The viewport when viewing the sliced part is slow, but that's what we get until it gets fixed for Nvidia users.

@anarsoul
Copy link
Contributor

until it gets fixed for Nvidia users

Someone needs to report it to NVIDIA, it's very likely to be their bug

@Skaifer
Copy link

Skaifer commented Dec 21, 2024

MackBambu at BambuStudio thread says Nvidia has dropped old OpenGL version support, so they are now working on a fix, which hopefully would eventually come to OrcaSlicer and heal our sores.

@egruttum
Copy link

I created a repo with (fixed) flatpak manifest for OrcaSlicer: https://github.com/anarsoul/io.github.softfever.OrcaSlicer

Flatpak for v2.2.0 can be found here: https://github.com/anarsoul/io.github.softfever.OrcaSlicer/releases/tag/v2.2.0-1

Thank you for this. I drove myself crazy trying to make OrcaSlicer work on my Chromebook with the AppImage. This worked so easily. Hopefully this gets into the official Flatpak repository someday to make it even easier for people to find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests