From 6697c057a7088ce081e9c4d5344df8643355680f Mon Sep 17 00:00:00 2001 From: Ou Ku Date: Fri, 20 Sep 2024 16:42:50 +0200 Subject: [PATCH 1/3] Apply suggestions from code review Co-authored-by: Francesco Nattino <49899980+fnattino@users.noreply.github.com> --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 7c4f94b..e7f935b 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ -# PyDePSI (Tenative name) +# PyDePSI (Tentative name) -This is the repository of WIP, where we are developing a Python package for inteferometric SAR processing. The software will be inspired by the MATLAB software DePSI, but implemented in Python and include recent developments in the field. +This is repository is WIP, where we are developing a Python package for inteferometric SAR processing. The software will be inspired by the MATLAB software DePSI, but implemented in Python and include recent developments in the field. ## Installation for development @@ -24,7 +24,7 @@ Here we use Python 3.12 since we aim to support python 3.10 and above. Activate the environment: ```bash -conda activate pydepsi-dev +mamba activate pydepsi-dev ``` Install this package in development mode: From d33475d2abcff33a8fec9ed547d4ee03ac8b42b9 Mon Sep 17 00:00:00 2001 From: Ou Ku Date: Fri, 20 Sep 2024 16:48:48 +0200 Subject: [PATCH 2/3] Apply suggestions from code review --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index e7f935b..62e5b43 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ cd PyDePSI Create a new conda environment (here we give an example name `pydepsi-dev`) with `mamba`.: ```bash -mamba create -n pydepsi-dev python=3.12 +mamba create -c conda-forge -n pydepsi-dev python=3.12 ``` Here we use Python 3.12 since we aim to support python 3.10 and above. @@ -38,7 +38,7 @@ In the end, install the pre-commit hooks: pre-commit install ``` -## References +## Useful reading material - [Python packaging user guide](https://packaging.python.org/) - [Testing in Python](https://docs.kedro.org/en/stable/development/automated_testing.html) From 127e39bb16501d983cb4a57223c484e6f5b228f6 Mon Sep 17 00:00:00 2001 From: Ou Ku Date: Fri, 20 Sep 2024 16:56:23 +0200 Subject: [PATCH 3/3] update github action --- .github/workflows/build.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 28d82f5..fff3c1c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -30,7 +30,5 @@ jobs: python -m pip install --upgrade pip python -m pip install build python -m pip install .[dev,docs,demo] - - name: Build the package - run: python -m build - name: Test with pytest run: python -m pytest