-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Villager trading issues. #1
Comments
The trade prices seem to reset occasionally from my tests, for the over the stack im not entirely sure why it goes to 65 rather than default back to max stack size if something was broken |
Oh also, the trading menu is closed and opened very quickly everytime you trade, doing it manually should theoretically make no difference, as the inventory opens again when the plugin is complete with its logic |
Also, when the trade prices reset for me, I can still buy those items, and it doesnt revert back to what it was when I reopen the menu, its a permanent change. Is your server running Spigot or Paper? |
My server is running Paper. What I mean by the trades resetting is that when the villagers reduce the price of a trade, it is back to regular pricing after trading once or more with the trading interface kept open. |
Im not entirely sure if I can prevent that from happening. As the discounts arent stored in the TradeOffer, but somewhere else that ive got no idea how to access |
Currently, when you trade, all the trade offers are looped through then their result count is increased, and I know discounts arent stored inside the TradeOffer, so im really not sure how I would fix it |
I retested the over a stack issue and what exactly seems to be happening is that if you shift click the result, you get a single item and a stack of it at the same time, but if you just grab it with the mouse, you only get a stack. |
I have an idea for how to fix it, I didnt think it would need to be fixed since I thought MC would handle the over 64 stack in the villager menu. It seems I actually need to fake it a bit |
There is an issue where taking items out of the villager trade result slot only gives you 65 items if the result is more than a stack, even if you shift click. Also the trade prices reset every time you trade, which means you have to reopen the trading interface every time after a trade if you want to see the right trade prices.
The text was updated successfully, but these errors were encountered: