Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package tendrl-api-doc is not useful for tendrl admin #218

Open
mbukatov opened this issue Jun 23, 2017 · 5 comments
Open

Package tendrl-api-doc is not useful for tendrl admin #218

mbukatov opened this issue Jun 23, 2017 · 5 comments

Comments

@mbukatov
Copy link
Contributor

Package with api documentation tendrl-api-doc contains files which are already packaged somewhere else without explanation which would be helpful in rpm installed product context.

This unfortunately means that the doc package provides no value for the user in it's current form.

Details of the problem

# rpm -ql tendrl-api-doc
/usr/share/doc/tendrl/README.adoc
/usr/share/doc/tendrl/Rakefile
/usr/share/doc/tendrl/config
/usr/share/doc/tendrl/config/apache.vhost.sample
/usr/share/doc/tendrl/config/etcd.sample.yml
/usr/share/doc/tendrl/config/tendrl.sample.yml

Rakefile is the same as in tendrl-api package (what is the purpose of this?):

# diff /usr/share/tendrl-api/Rakefile /usr/share/doc/tendrl/Rakefile
#

File etcd.sample.yml the same as default configuration of tendrl-api:

# diff /etc/tendrl/etcd.yml /usr/share/doc/tendrl/config/etcd.sample.yml
#

The same holds for apache configuration shipped in tendrl-api-httpd:

# diff /usr/share/doc/tendrl/config/apache.vhost.sample /etc/httpd/conf.d/tendrl.conf
#

And last but not least, the purpose of tendrl.sample.yml is unknown when someone opens it for the first time.

Which brings me the the main problem here: the readme file packaged there is the readme file from the tendrl-api git repository and it doesn't provide any explanation what the example config files are for, and most of the information are not suitable for installation from rpm packages.

Version

tendrl-api-1.4.2-1.el7.centos.noarch
tendrl-api-doc-1.4.2-1.el7.centos.noarch

Additional information

I'm not against shipping example configuration files or readme, but to make this package useful, we would need to think over what is the purpose of each sample file and write that down into a readme file - or to drop the docs package completely.

@mbukatov mbukatov changed the title Package tendrl-api-doc needs tweaking Package tendrl-api-doc is not useful for tendrl admin Jun 23, 2017
@r0h4n
Copy link
Contributor

r0h4n commented Aug 8, 2017

@anivargi please respond to this

@TimothyAsirJeyasing
Copy link
Contributor

TimothyAsirJeyasing commented Oct 11, 2017

The main intention of this package into TENDRL is to provide a sample documentation about how to use and the useful configurations. As of now we dont have any examples or any specific configuration for fine tuning. If it's really not required or might not useful in feature enhancements we can remove this package.
@anivargi Please share your views.

@anivargi
Copy link
Contributor

We don't have any specific doc that can be part of tendrl-api-doc, we can add this when we have proper useful documentation in the future.

@mbukatov
Copy link
Contributor Author

@anivargi does this mean that we are going to drop tendrl-api-doc package until we have something interesting to put there? I'm asking because in the last snapshot build I still see the doc package.

TimothyAsirJeyasing added a commit to TimothyAsirJeyasing/tendrl-api that referenced this issue Nov 9, 2017
tendrl-bug-id: Tendrl#218

Signed-off-by: Timothy Asir J <[email protected]>
@TimothyAsirJeyasing
Copy link
Contributor

TimothyAsirJeyasing commented Feb 1, 2018

You can close this issue because its already addressed and reopen if you still find any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants