Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruby version to 2.0.0-p648 #376

Open
shirshendu opened this issue Mar 5, 2018 · 6 comments
Open

Upgrade ruby version to 2.0.0-p648 #376

shirshendu opened this issue Mar 5, 2018 · 6 comments
Assignees

Comments

@shirshendu
Copy link

shirshendu commented Mar 5, 2018

This is the latest available system ruby on RHEL/CentOS, and only needs a small change.
This is the interim step before we put in more work to use later versions of ruby - #377
The current .ruby-version file for this project has 2.0.0-p598; it is possible that some deployments are already using p648, so we need to start building gems against p648 as well.

@shirshendu shirshendu self-assigned this Mar 5, 2018
@r0h4n
Copy link
Contributor

r0h4n commented Mar 6, 2018

@TimothyAsir What are the risks for moving the current ruby version used for tendrl-api to version 2.0.0 for RHEL

@TimothyAsirJeyasing
Copy link
Contributor

TimothyAsirJeyasing commented Mar 6, 2018

(for ds) Its already available in rhel-7-server-rpms channel. The current available version is 2.0.0.648-33.el7_4 which will be installed while installing tendrl-api.

ruby, ruby-libs, ruby-irb -> 2.0.0.648-33.el7_4
and i feel 2.4.2 is planned for rhel8 to avoid impact on existing gems (need to verify)

@shtripat
Copy link
Member

shtripat commented Mar 6, 2018

In that case we can give a try but any impact on the gems we are using/building?

@mbukatov
Copy link
Contributor

mbukatov commented Mar 6, 2018

You are right about the latest version of ruby available on RHEL/CentOS 7, it's ruby-2.0.0.648-33.el7_4.

But I don't understand what small change you have in mind in the description of this issue. We will use this particular ruby version when deploying on up to date RHEL system, we don't have to change anything on our side to use it.

But I see two occurrences of some a ruby version ruby 2.0.0p598 in 2 files:

$ git grep -i ruby\ 2.0
Gemfile.lock:   ruby 2.0.0p598
README.adoc:. Install Ruby 2.0.0p598.

If you mean updating those, I'm ok with it.

Btw, that ruby version in Gemfile.lock is important for dev environment only, right?

@shirshendu
Copy link
Author

shirshendu commented Mar 6, 2018

@mbukatov the way we are deploying through RPMs, we cannot control which patch version of ruby to depend on. However, Gemfile.lock is integral to the RPM build process.
Apart from the Gemfile.lock file, we also need to update the .ruby-version file, which is the one that will change the ruby dependency of the project. That's how we specify ruby version dependency of a project, and package managers, ruby version managers tend to respect it.

@shirshendu
Copy link
Author

shirshendu commented Mar 6, 2018

Its already available in rhel-7-server-rpms channel. The current available version is 2.0.0.648-33.el7_4 which will be installed while installing tendrl-api.

Nice, this means there is no downstream dependency of the change I wish to make. Thanks for the info @TimothyAsirJeyasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants