Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the frequency plans repository #38

Open
3 tasks
adriansmares opened this issue Jul 2, 2021 · 3 comments · May be fixed by #62
Open
3 tasks

Reorganize the frequency plans repository #38

adriansmares opened this issue Jul 2, 2021 · 3 comments · May be fixed by #62
Assignees
Milestone

Comments

@adriansmares
Copy link
Contributor

Summary

Based on our earlier call regarding newer regional parameters, we have discussed that the following changes should be done to this repository:

  • We should start versioning the repository (one branch per version)
  • The gateway frequency plans should be separated from the end device frequency plans
    • The gateway frequency plans don't have to be versioned (on a per regional parameters basis) - they represent the latest version, and data rate ranges are not required
  • The definition of the frequency plans should be moved to this repository. This allows CI to be added and the content of the frequency plans to be validated.

Why do we need this?

In order to support newer regional parameters versions.

What is already there? What do you see now?

Only master, containing frequency plans combining both gateways and end devices.

What is missing? What do you want to see?

  • One branch per version
  • Top level folders for end device frequency plan definitions, and for gateway frequency plan definitions
  • A Go package that exposes the schema for these definitions

Can you do this yourself and submit a Pull Request?

Can review and assist when needed.

@adriansmares adriansmares added this to the 2021 Q3 milestone Jul 2, 2021
@github-actions github-actions bot added the needs/triage We still need to triage this label Jul 2, 2021
@nejraselimovic nejraselimovic removed the needs/triage We still need to triage this label Jul 7, 2021
@adriansmares
Copy link
Contributor Author

References TheThingsNetwork/lorawan-stack#4196

@htdvisser htdvisser removed this from the 2021 Q3 milestone Sep 23, 2021
@htdvisser
Copy link
Contributor

Removing milestone since TheThingsNetwork/lorawan-stack#4196 is still unplanned

@ysmilda
Copy link
Contributor

ysmilda commented Nov 16, 2022

I agree that we need to version the plans, but I'm not sure that doing that by different branches will be the way to do that.

Currently the stacks imports the frequency-plans as a submodule. When going with branch versioning the stack won't easily be able to import all versions this way. Wouldn't folder based versioning fit better?

@adriansmares adriansmares assigned ysmilda and unassigned adriansmares Nov 29, 2022
@ysmilda ysmilda linked a pull request Dec 9, 2022 that will close this issue
4 tasks
@NicolasMrad NicolasMrad modified the milestones: 2022 Q4, 2023 Q1 Jan 2, 2023
@NicolasMrad NicolasMrad assigned adriansmares and unassigned ysmilda Apr 12, 2023
@NicolasMrad NicolasMrad removed this from the 2023 Q1 milestone Apr 12, 2023
@NicolasMrad NicolasMrad added this to the 2023 Q2 milestone Apr 12, 2023
@KrishnaIyer KrishnaIyer modified the milestones: 2023 Q2, Backlog Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants