Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs mention code that doesn't exist #6

Open
boanergies opened this issue Oct 21, 2020 · 1 comment
Open

Docs mention code that doesn't exist #6

boanergies opened this issue Oct 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@boanergies
Copy link

In your guide for using the WeatherStation kit, near the end it mentions the following lines of code being in the WeatherStationdemo code:

//Thingspeak Settings
const String THINGSPEAK_CHANNEL_ID = "67824";\n
const String THINGSPEAK_API_READ_KEY = "L2VIW20QVNZJBLAK";

Looking at your past commits for the WeatherStationDemo it seems like you removed these lines at one point and then never put it back. Your tutorial encourages the user to replace these two lines with our own channel id and api read key but now they don't exist at all in the code. Is this a typo? Or is it expected the user is supposed to write it in themselves and figure out how to use the thingspeak client?

@marcelstoer
Copy link
Member

Thanks for reporting this issue! @squix78 and I will discuss this.

From what I understand this appears to be about the chapter "Collecting and Displaying Local Data", more specifically the paragraph "Displaying the data on the WeatherStation".

Looking at your past commits for the WeatherStationDemo it seems like you removed these lines

More than that, with ThingPulse/esp8266-weather-station@1866c60#diff-5e6b4def031fa9bf8efb76e3e99450293de68459125f96f12a2273021bdab369 the whole ThingspeakClient integration was removed.

@marcelstoer marcelstoer added the bug Something isn't working label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants