Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential security issue #2

Open
ghost opened this issue Jan 26, 2024 · 1 comment
Open

Potential security issue #2

ghost opened this issue Jan 26, 2024 · 1 comment

Comments

@ghost
Copy link

ghost commented Jan 26, 2024

if (!event.getView().getTitle().contains("SkyBlock Items")) return;

Checking event.getView().getTitle() to see whether your custom inventory is being used is unsafe, as renaming a chest in an anvil allows users to set their own inventory titles. The correct way to check if your custom inventory is involved with an event is by using custom holders, see here: https://docs.papermc.io/paper/dev/custom-inventory-holder

@Thomassc10
Copy link
Owner

Hey, thanks for tip, I wasn't aware of that. This is kinda of an abandoned project tho, I haven't been coding plugins for a while now and I don't think I'll get back to it. Just out of curiosity, how did you find this repository? Sorry for the delay btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant