diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b284f3f9..c9f4da9f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,21 +32,6 @@ jobs: with: command: test - coverage: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - uses: actions-rs/toolchain@v1 - with: - profile: minimal - toolchain: stable - override: true - - run: cargo install cargo-tarpaulin - - run: cargo tarpaulin --verbose --all-features --workspace --timeout 120 --out xml --avoid-cfg-tarpaulin - - uses: codecov/codecov-action@v3 - with: - fail_ci_if_error: true - fmt: name: fmt runs-on: ubuntu-latest diff --git a/src/net.rs b/src/net.rs index c097365b..794c3f7b 100644 --- a/src/net.rs +++ b/src/net.rs @@ -46,11 +46,11 @@ pub trait Signable { } #[derive(Clone, Serialize, Deserialize, Debug, PartialEq)] -/// +/// A bad private share pub struct BadPrivateShare { - /// + /// the DH shared key between these participants pub shared_key: Point, - /// + /// prooof that the shared key is a valid DH tuple as per chaum-pedersen pub tuple_proof: TupleProof, } @@ -195,7 +195,7 @@ pub struct DkgPrivateShares { } impl DkgPrivateShares { - /// + /// Verify that the shares are good pub fn verify() -> bool { true } diff --git a/src/state_machine/coordinator/fire.rs b/src/state_machine/coordinator/fire.rs index 4e30950d..34f10eec 100644 --- a/src/state_machine/coordinator/fire.rs +++ b/src/state_machine/coordinator/fire.rs @@ -803,7 +803,7 @@ impl Coordinator { ); if nonce_info.nonce_recv_key_ids.len() >= self.config.threshold as usize { // We have a winning message! - self.message = nonce_response.message.clone(); + self.message.clone_from(&nonce_response.message); let aggregate_nonce = self.compute_aggregate_nonce(); info!("Aggregate nonce: {}", aggregate_nonce); diff --git a/src/state_machine/signer/mod.rs b/src/state_machine/signer/mod.rs index 49ef2d80..8d4dca23 100644 --- a/src/state_machine/signer/mod.rs +++ b/src/state_machine/signer/mod.rs @@ -275,7 +275,7 @@ impl Signer { self.state = State::Idle; } - /// + /// Process the slice of packets pub fn process_inbound_messages(&mut self, messages: &[Packet]) -> Result, Error> { let mut responses = vec![]; for message in messages {