Member script injected when url:false is set

[ltoinel]

Issue Summary

The issue #12865 seems to be back ... since the 5.104.0 or maybe before.

When "false" is used as URL like described in the documentation : https://ghost.org/docs/config/

"The script can be relocated by changing the URL, or disabled entirely by setting "url": false."

The member script is injected in the page with "false" as a URL creating 404 error on web spiders :
<script defer src="false" data-i18n="true" data-ghost="https://www.geeek.org/" data-key="xxxxx" data-api="https://www.geeek.org/ghost/api/content/" data-locale="fr" crossorigin="anonymous"></script>

Steps to Reproduce

Disable the portal in the config file
"portal": { "url": false },

Ghost Version

5.105.0

Node.js Version

18.20.5

How did you install Ghost?

Linux Ubuntu self hosting

Database type

MySQL 5.7

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

• I agree to be friendly and polite to people in this repository

[kevinansfield]

Setting the portal url to false has never been supported so this isn't a recent regression.

If you don't want the core portal script (or a custom version) to be loaded then you'll need to disable members, donations, and recommendations in your site settings. If you use any of those features you'll need the portal script to be present for them to work.

[ltoinel]

@kevinansfield : Documentation issue ?
"The script can be relocated by changing the URL, or disabled entirely by setting "url": false."
https://ghost.org/docs/config/

[ltoinel]

If found my issue, recommandations needs also to be disabled to avoid to load the portal JS helper in the header.

if (!settingsCache.get('members_enabled') && !settingsCache.get('donations_enabled') && !settingsCache.get('recommendations_enabled')) {
        return '';
}

The "url": false" has no effect and should be removed from the documentation or we have to add :

if (!scriptUrl) {
        return '';
}

In the getMembersHelper function, like the getSearchHelper function.

#21936